-
-
Notifications
You must be signed in to change notification settings - Fork 183
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Interfaces ZMI Tab on Plone site root broken #2083
Comments
I'm seening this too. It works with 5.1b3 but not with 5.1b4-pending |
Apparently the same utility (
|
I did some digging but only found out that searchInterfaceUtilities(
context = <Products.Five.utilities.marker.MarkerInterfacesAdapter object at 0x109339550>,
search_string = None,
base = <InterfaceClass plone.app.contentmenu.interfaces.IContentMenuItem>) returns [] in 5.0b3 but 2 items in 5.0b4:
Maybe this is helpful for someone. |
Also: When we ignore the line |
Pinning back zope.component to 3.12.1 works :) The commit causing the error is this one: Probably @MrTango had a good reason for that upgrade (Python 3 compatibility?). Once there was also a warning about not upgrading zope.component: Thanks for the great work you are doing! |
@ale-rt I am glad I could help :) |
Pining back
|
Investing some more time I found the relevant difference: In zope.component 3.12.1 the method [iface_util for iface_util in iface_utilities if iface_util[1].isOrExtends(base)] in 4.3.0 is uses: [iface_util for iface_util in iface_utilities if iface_util[1].extends(base)]
It is the change zopefoundation/zope.component@2e39b26#diff-65de6b69a0342d33e93d0098ac38b46cL220 from 2012! Good night for now. |
Also: With the old behavior ( |
I discuss solutions to this in zopefoundation/zope.component#32. |
This is the pull-request that fixes this: zopefoundation/zope.component#33 |
Fixed |
If you go to ZMI -> Plone Site Root -> Interfaces Tab in a naked latest coredev 5.1 buildout a traceback pops up
The text was updated successfully, but these errors were encountered: