Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resource Registry: plone-compile-resources always compies a file name BUNDLENAME-compiled, regardless what's configured in js/csscompilation #2437

Closed
thet opened this issue Jun 2, 2018 · 1 comment

Comments

@thet
Copy link
Member

thet commented Jun 2, 2018

I have a registry.xml like the following:

<?xml version="1.0"?>
<registry>

  <!-- ... -->

  <records prefix="plone.bundles/collectionfilter-bundle"
              interface='Products.CMFPlone.interfaces.IBundleRegistry'>
    <value key="resources">
      <element>collectionfilter-bundle</element>
    </value>
    <value key="enabled">True</value>
    <value key="compile">True</value>
    <value key="jscompilation">++resource++collective.collectionfilter/collectionfilter-compiled.js</value>
    <value key="csscompilation">++resource++collective.collectionfilter/collectionfilter-compiled.css</value>
  </records>

</registry>

When compiling with ./bin/plone-compile-resources -b collectionfilter-bundle the resulting js file is collectionfilter-bundle-compiled.jsbut the file which is configured injscompilation-collectionfilter-compiled.js`` is used.

plone-compile-resources should rather use the file name configured in jscompilation.

thet added a commit to collective/collective.collectionfilter that referenced this issue Jun 2, 2018
Register the bundle compile files as ``collectionfilter-bundle-compiled.js`` and ``collectionfilter-bundle-compiled.css``, so that using ``plone-compile-resources`` results in the same files.
See: plone/Products.CMFPlone#2437
@thet
Copy link
Member Author

thet commented Aug 24, 2022

Probably won't fix. Plone 6 is totally different and in Plone 5 only a few understand the RR‌ as it is broken in many way. Would not bring a big benefit fixing this.
Unless you do it!

@thet thet closed this as not planned Won't fix, can't repro, duplicate, stale Aug 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants