Datatables CSS not available

[thet]

The current plone-logged-in-compiled.min.css bundle file does not directly include the datatables css files but tries to import them. Also the paths are wrong which leads to a bunch of 404's - at least for me. See the first line here:

https://github.com/plone/Products.CMFPlone/blob/7cefb8f47585422c182e04ae15b08dd2ea456616/Products/CMFPlone/static/plone-logged-in-compiled.css

The CSS files mist be included inline.
This - among other things - fixes this problem:

plone/mockup#863

/cc @plone/framework-team @plone/release-team

[frapell]

@thet To be honest, I don't know what's the proper way to do it... I tend to prefer (inline), since this way all of the css are included in one big css, and I can backport a bunch of this functionality back to 4.3 instances for customers, without much hassle. In fact, this particular datatables feature was made for a 4.3 instance, where I have to manually compile the whole thing, and also include the modules so the import would work...

Now, @datakurre had an issue with this in plone/mockup@1d944a9 where he needed to replace (inline) to be (css). That's why I am trying to use (css), and so, I included the needed modules in https://github.com/plone/Products.CMFPlone/tree/master/Products/CMFPlone/static/components

I am fine with whatever, but it would be great if we could decide on which to use going forward (If there is documentation about this somewhere, I have missed it)

[datakurre]

I’m sorry about that. I didn’t realise that difference between inline and css imports. The difference with webpack was that css import let webpack’s css loader to do the inlining fixing some lookup issues with less loader (it was unable to find relative paths linked from unlined css because of lost original folder context). So, probably you should revert and use inline, and I should figure out if less loader could patch those inline imports to css imports.

…

On 10 Sep 2018, 17.24 +0300, Franco Pellegrini ***@***.***>, wrote: @thet To be honest, I don't know what's the proper way to do it... I tend to prefer (inline), since this way all of the css are included in one big css, and I can backport a bunch of this functionality back to 4.3 instances for customers, without much hassle. In fact, this particular datatables feature was made for a 4.3 instance, where I have to manually compile the whole thing, and also include the modules so the import would work... Now, @datakurre had an issue with this in ***@***.*** where he needed to replace (inline) to be (css). That's why I am trying to use (css), and so, I included the needed modules in https://github.com/plone/Products.CMFPlone/tree/master/Products/CMFPlone/static/components I am fine with whatever, but it would be great if we could decide on which to use going forward (If there is documentation about this somewhere, I have missed it) — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or mute the thread.

[sunew]

Fixed after:
plone/mockup#863
#2515
plone/plone.app.upgrade#171

A re-bundling is needed - either by running upgrade steps to 5.1.4 or 5.2.alpha1, or by manually running portal_setup -> Advanced import -> CMFPlone:dependencies profile -> Bundle combination
(deselect "Include dependencies of steps")