Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Toolbar: Wrong position of content #3236

Closed
csenger opened this issue Feb 4, 2021 · 1 comment
Closed

Toolbar: Wrong position of content #3236

csenger opened this issue Feb 4, 2021 · 1 comment

Comments

@csenger
Copy link

csenger commented Feb 4, 2021

What I did:

Have a Window that is not as high as the content of the contentmenu in the toolbar. E.g. the Add...-Menu with a lot of types in it.

What I expect to happen:

The contentmenu has the full height of the window and a scrollbar and is fully visible

What actually happened:

The contentmenu has a negative margin-top. Only the lower part is visible.

image

The code in mockup should be limited to a minumum margin-top of 0:

https://github.com/plone/mockup/blob/5e71d149beacbebc97eef2cf8693b1a706431923/mockup/patterns/toolbar/pattern.js#L324-L331

What version of Plone/ Addons I am using:

Plone CMFPlone 5.2.2., mockup 3.2.2, plone.staticresources 1.3.2

@jensens
Copy link
Sponsor Member

jensens commented Mar 12, 2023

AFAICT it works fine in Plone 6. Please reopen if I am wrong.

@jensens jensens closed this as completed Mar 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants