Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

edit-bar still shown on public page when default theme is deactivated. #471

Closed
ivanteoh opened this issue May 1, 2015 · 6 comments
Closed

edit-bar still shown on public page when default theme is deactivated. #471

ivanteoh opened this issue May 1, 2015 · 6 comments

Comments

@ivanteoh
Copy link
Member

ivanteoh commented May 1, 2015

When I deactivate the default theme in Plone 5.0a3, The edit-bar still there on the public front page. I believe it shouldn't be there.
ubuntu_64_1204 running - oracle vm virtualbox_482
@vangheem
Copy link
Member

vangheem commented May 1, 2015

What version? What do you mean by "When I deactivate the default Plone"? I can't reproduce this.

@ivanteoh
Copy link
Member Author

ivanteoh commented May 1, 2015

Typo on my comment. Added screen shot and Plone version.

@vangheem
Copy link
Member

vangheem commented May 1, 2015

Still doesn't make sense. What do you mean by "When I deactivate the default theme"?

@ivanteoh
Copy link
Member Author

ivanteoh commented May 1, 2015

When I go to theming-controlpanel and deactivate Barceloneta Theme.
ubuntu_64_1204 running - oracle vm virtualbox_483

@vangheem
Copy link
Member

vangheem commented May 1, 2015

Ah I see. Not sure what you are trying to accomplish by disabling a theme though.

@ivanteoh
Copy link
Member Author

ivanteoh commented May 1, 2015

I was playing around the new theme and accidentally found. :)

vangheem added a commit to plone/buildout.coredev that referenced this issue May 1, 2015
@vangheem
[fc] Repository: Products.CMFPlone
40b2399 
Branch: refs/heads/master
Date: 2015-05-01T00:20:26-05:00
Author: vangheem (vangheem) <vangheem@gmail.com>
Commit: plone/Products.CMFPlone@6b1f6f3

only show edit bar if user logged in closes plone/Products.CMFPlone#471

Files changed:
M CHANGES.rst
M Products/CMFPlone/browser/templates/main_template.pt
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@vangheem @ivanteoh