Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change shortname via the edit form of a document raise a WebDAV lock Error on Plone 5b2 #623

Closed
loechel opened this issue Jun 14, 2015 · 0 comments · Fixed by plone/plone.app.dexterity#171
Closed

Change shortname via the edit form of a document raise a WebDAV lock Error on Plone 5b2 #623

loechel opened this issue Jun 14, 2015 · 0 comments · Fixed by plone/plone.app.dexterity#171
Assignees
@pbauer
Labels
01 type: bug 99 tag: sprint 99 tag: UX Editor
Milestone
Plone 5.0

Comments

@loechel
Copy link
Member

loechel commented Jun 14, 2015

During Plone Symposium Tokyo we spotted that if you try to rename the short-name of a content object via the edit form in Plone 5B2 it raise a ResourceLockedError

Full Traceback

Traceback (innermost last):

Module ZPublisher.Publish, line 138, in publish
Module ZPublisher.mapply, line 77, in mapply
Module ZPublisher.Publish, line 48, in call_object
Module plone.z3cform.layout, line 66, in call
Module plone.z3cform.layout, line 50, in update
Module plone.dexterity.browser.edit, line 65, in update
Module plone.z3cform.fieldsets.extensible, line 59, in update
Module plone.z3cform.patch, line 30, in GroupForm_update
Module z3c.form.group, line 145, in update
Module plone.app.z3cform.csrf, line 21, in execute
Module z3c.form.action, line 98, in execute
Module z3c.form.button, line 315, in call
Module z3c.form.button, line 170, in call
Module plone.dexterity.browser.edit, line 29, in handleApply
Module z3c.form.group, line 116, in applyChanges
Module z3c.form.group, line 82, in applyChanges
Module z3c.form.form, line 50, in applyChanges
Module z3c.form.datamanager, line 91, in set
Module plone.app.dexterity.behaviors.id, line 52, in _set_id
Module plone.folder.ordered, line 187, in manage_renameObject
Module OFS.CopySupport, line 354, in manage_renameObject

ResourceLockedError: Object "test" is locked via WebDAV

The short name isn't hidden by default anymore so it need to work out of the box.
@loechel loechel added this to the Plone 5 milestone Jun 14, 2015
@pbauer pbauer self-assigned this Jul 13, 2015
pbauer added a commit to plone/plone.app.dexterity that referenced this issue Jul 13, 2015
@pbauer
unlock before changing id (fixes plone/Products.CMFPlone#623)
599ab25
@pbauer pbauer mentioned this issue Jul 13, 2015
Merged
jensens added a commit to plone/buildout.coredev that referenced this issue Jul 14, 2015
@jensens
[fc] Repository: plone.app.dexterity
c8eba77 
Branch: refs/heads/master
Date: 2015-07-13T16:36:52+02:00
Author: Philip Bauer (pbauer) <bauer@starzel.de>
Commit: plone/plone.app.dexterity@599ab25

unlock before changing id (fixes plone/Products.CMFPlone#623)

Files changed:
M plone/app/dexterity/behaviors/id.py
Repository: plone.app.dexterity
Branch: refs/heads/master
Date: 2015-07-14T13:00:08+02:00
Author: Philip Bauer (pbauer) <bauer@starzel.de>
Commit: plone/plone.app.dexterity@841c065

simplify unlocking

Files changed:
M plone/app/dexterity/behaviors/id.py
Repository: plone.app.dexterity
Branch: refs/heads/master
Date: 2015-07-14T13:13:11+02:00
Author: Philip Bauer (pbauer) <bauer@starzel.de>
Commit: plone/plone.app.dexterity@bb4bbb1

test unlocking (before it resulted in "HTTPError: HTTP Error 423: Locked")

Files changed:
M plone/app/dexterity/behaviors/tests/test_id.py
Repository: plone.app.dexterity
Branch: refs/heads/master
Date: 2015-07-14T17:17:18+02:00
Author: Jens W. Klein (jensens) <jk@kleinundpartner.at>
Commit: plone/plone.app.dexterity@aacb332

Merge pull request #171 from plone/fix_renaming

Unlock before changing id

Files changed:
M plone/app/dexterity/behaviors/id.py
M plone/app/dexterity/behaviors/tests/test_id.py
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pbauer pbauer

Labels
01 type: bug 99 tag: sprint 99 tag: UX Editor
Projects
None yet
Milestone
Plone 5.0
Development

Successfully merging a pull request may close this issue.

Unlock before changing id plone/plone.app.dexterity
3 participants
@pbauer @tisto @loechel