-
-
Notifications
You must be signed in to change notification settings - Fork 182
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Incomplete mapping of language names in control panel #824
Comments
still an issue |
Still valid in Plone 6 |
So to fix it, you edit I suppose it is logical that the English name is not used as fallback: if the user does not understand English, then she may not recognise the English name. "German" and "Deutsch" do not even begin with the same character. I will add a few for German and Dutch. |
…iants. Then all related language variants are shown together in the language control panel. Fixes plone/Products.CMFPlone#824, at least for these two languages.
@mauritsvanrees I could imagine a fancy fallback that looks for a translation of the non-country-specific variation name of the language, then adds the 2-char country code in parentheses. But it is probably easier to just add the native names manually. |
Branch: refs/heads/master Date: 2022-08-25T01:13:47+02:00 Author: Maurits van Rees (mauritsvanrees) <maurits@vanrees.org> Commit: plone/plone.i18n@d447fc2 Added native names for German and Dutch country-specific language variants. Then all related language variants are shown together in the language control panel. Fixes plone/Products.CMFPlone#824, at least for these two languages. Files changed: A news/824.bugfix M plone/i18n/locales/languages.py Repository: plone.i18n Branch: refs/heads/master Date: 2022-08-25T17:31:39+02:00 Author: Jens W. Klein (jensens) <jk@kleinundpartner.at> Commit: plone/plone.i18n@57cda76 Merge pull request #44 from plone/maurits-native-names-de-nl Added native names for German and Dutch language variants Files changed: A news/824.bugfix M plone/i18n/locales/languages.py
Not really complete; that PR only fixed it for German and Dutch |
wtf, automatic close ... |
@jensens yeah I know, no worries |
In our language list in plone.i18n we have native names only for language names and not for language-country variants (except some of them). I added a PR fixing this in plone.i18n for many languages (mainly the big ones like |
Thanks @erral! I think this can be closed now. Doing so. |
for example de-at maps to "Deutsch (Österreich)", de-ch is not mapped to a label
where does the "magic" happen here?
The text was updated successfully, but these errors were encountered: