Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump to lxml 3.x #857

Closed
esteele opened this issue Sep 3, 2015 · 6 comments
Closed

Bump to lxml 3.x #857

esteele opened this issue Sep 3, 2015 · 6 comments

Comments

@esteele
Copy link
Sponsor Member

esteele commented Sep 3, 2015

I'd like to see us move to lxml 3.x (currently 3.4.4) before we cut the Plone 5 release. We're currently stuck on a version from 2011.

See this thread from plone-developers for some background.

At the time, the largest issue was the lack of Windows binaries. Unofficial builds are available, and since we're not doing Windows installers at the moment, this is mostly moot.

@esteele esteele added this to the Plone 5.0 milestone Sep 3, 2015
@esteele
Copy link
Sponsor Member Author

esteele commented Sep 3, 2015

cssselect has now been split out of lxml proper and Plone won't run without that installed.

Looking at it, I think two of the fixes in experimental.cssselect are now also in csseelect:

So the remaining one would be "use the xpath 'A//B' (short for 'A/descendant-or-self::node()/B') instead of 'A/descendant::B' for the css descendant selector ('A B').", which I haven't been able to find (and TBH, don't completely understand).

@esteele
Copy link
Sponsor Member Author

esteele commented Sep 3, 2015

For that last one, running
_unicode(GenericTranslator().css_to_xpath('A B', prefix='')) through cssselector results in u'A/descendant-or-self::*/B'

@esteele
Copy link
Sponsor Member Author

esteele commented Sep 3, 2015

See plone/diazo@62befdd

@tisto
Copy link
Sponsor Member

tisto commented Sep 3, 2015

+1 Let me know if you need a jenkins job to test this...

@esteele
Copy link
Sponsor Member Author

esteele commented Sep 3, 2015

@tisto: Yes, please. That'd be great.

@esteele esteele closed this as completed Sep 3, 2015
thet added a commit that referenced this issue Oct 5, 2018
thet added a commit that referenced this issue Oct 5, 2018
thet added a commit that referenced this issue Oct 5, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants