Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Toolbar Buttons Are Not Operable by Keyboard on Plone5b4 #866

Closed
ma10 opened this issue Sep 6, 2015 · 5 comments
Closed

Toolbar Buttons Are Not Operable by Keyboard on Plone5b4 #866

ma10 opened this issue Sep 6, 2015 · 5 comments
Labels
01 type: bug 99 tag: UX Accessibility Issues that specifically impact a11y
Milestone

Comments

@ma10
Copy link

ma10 commented Sep 6, 2015

Plone5 beta 4 seems to have issues with keyboard operation on some of the toolbar buttons.

I assume if you hit Enter on the "Add New" or "State: published," a submenu would show up, but no changes that can be detected by screen reader happens.

How to reproduce the problem:

  1. Install the beta4 using the unified installer.
  2. create a new Plone site.
  3. Access the top page of the newly created site.
  4. Hit the Enter key on these buttons (technically links, I suppose.)

Tested environments:

  • Firefox 40.03 (32bit) with JAWS 14.0 on Windows
  • Firefox 40.03 (32bit) with NVDA 2015.3 on Windows
  • Google Chrome 45.0.2454.85 m (64-bit) with JAWS 14.0 on Windows
  • Google Chrome 45.0.2454.85 m (64-bit) with NVDA 2015.3 on Windows
@ma10
Copy link
Author

ma10 commented Sep 6, 2015

ps: This is also the case with the 'Translate' button when you enable plone.app.multilingual and add another language as a translatable language.

@polyester polyester added the 99 tag: UX Accessibility Issues that specifically impact a11y label Sep 9, 2015
@polyester polyester added this to the Plone 5.0 milestone Sep 9, 2015
@polyester
Copy link
Sponsor Member

@ma10 I am now checking on Plone5 rc2, using NVDA 2015.3, and the submenus do open correctly. Apart from annoying habit of having bulletpoints in front of them in the submenu it works as I would expect.

Cannot check in Jaws as I don't own it.

@ma10
Copy link
Author

ma10 commented Sep 15, 2015

@polyester:

I see, it does work if I do the following with NVDA (though not with JAWS):

  1. Hit enter on one of the buttons, e.g. "Add New."
  2. (NVDA switches to the "focus mode"), and hit the Tab key to move to the submenu items.

However, if you switch back to the browse mode by hitting Ins+SPC before hitting the tab key, it seems like NVDA can't recognize the submenu items. Users often expect that they can find the submenu items using the up/down cursor keys in the browse mode.

If it can be changed so that you can find the submenu items in NVDA's browse mode, I think the issue goes away with JAWS as well.

@polyester
Copy link
Sponsor Member

Thanks, I still need to learn a lot about how to operate NVDA properly (and one day JAWS). Will investigate.

@ma10
Copy link
Author

ma10 commented Sep 15, 2015

I played around a little more and found out the following.

  • JAWS's Forms Mode, or the virtual PC cursor off (which is equivalent to NVDA's focus mode) acts the same as NVDA's focus mode.
  • Regardless if you hit enter on toolbar buttons, if you keep hitting the tab key, you'll reach, and go through the submenu items.

This is in a sense better than how it used to be as with NVDA's browse mode or JAWS's virtual PC cursor, you don't have to read all the submenu items in order to go through the toolbar buttons.

But if you are not used to Plone's toolbar buttons and submenus, or you happen to know that yo would need to use the browse mode, you are quite lost.

Since I'm not an expert on the WAI-ARIA, I'm not too certain what's the best way to go about this, but I believe each button with submenu items should have "menu" for the role attribute and "true" for the aria-haspopup attribute, while submenu items should have "menuitem" for their role attributes. And aria-hidden attribute on submenu items must be adjusted accordingly.

Foe example, the simple dropdown menu example on this page seems to work fine.

@pbauer pbauer modified the milestones: Plone 5.0.x, Plone 5.0 Sep 19, 2015
terapyon added a commit to plonejp/Products.CMFPlone that referenced this issue Feb 18, 2016
mister-roboto pushed a commit to plone/buildout.coredev that referenced this issue Feb 18, 2016
Branch: refs/heads/master
Date: 2016-02-18T15:16:03+09:00
Author: Manabu TERADA (terapyon) <terada@cmscom.jp>
Commit: plone/Products.CMFPlone@64c404a

fix `aria-hidden` attribute control problem on toolbar
plone/Products.CMFPlone#866

Files changed:
M CHANGES.rst
M Products/CMFPlone/static/patterns/toolbar/src/toolbar.js
Repository: Products.CMFPlone
Branch: refs/heads/master
Date: 2016-02-18T12:00:05-06:00
Author: Nathan Van Gheem (vangheem) <vangheem@gmail.com>
Commit: plone/Products.CMFPlone@428e352

Merge pull request #1397 from plonejp/master

fix `aria-hidden` attribute control problem on toolbar

Files changed:
M CHANGES.rst
M Products/CMFPlone/static/patterns/toolbar/src/toolbar.js
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
01 type: bug 99 tag: UX Accessibility Issues that specifically impact a11y
Projects
None yet
Development

No branches or pull requests

4 participants