Fix social media schema field types #1967
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hvelarde
force-pushed
the
hvelarde-asciiline
branch
from
e1ea1a6
to
2234f3c
Compare
|
giving a second look I think we need to provide an upgrade step to cast those values to |
|
Do Twitter, Facebook and so on really only allow ASCII for the username? If you already check just discard my question, I'm only thinking aloud 😃 |
|
Twitter: Facebook: |
twitter_username, facebook_app_id and facebook_username should be ASCIILine instead of TextLine.
hvelarde
force-pushed
the
hvelarde-asciiline
branch
from
2234f3c
to
b8ab9ce
Compare
|
I need help with this; I don't understand Jenkins and I think failures are not related with my changes. |
|
There seems to be a general problem, see the first error on the console log: http://jenkins.plone.org/job/pull-request-5.1/1423/consoleFull |
|
found the issue, thanks! |
|
@plone/framework-team it's green, guys! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
twitter_username,facebook_app_idandfacebook_usernameshould beASCIILineinstead ofTextLine.refs. plone/plone.app.upgrade#107
refs. plone/plone.app.layout#121