Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

resolve issue in Products.CMFPlone.tests.testSSOLogin.TestSSOLoginIfr… #2186

Merged
merged 2 commits into from Oct 23, 2017
Merged

resolve issue in Products.CMFPlone.tests.testSSOLogin.TestSSOLoginIfr… #2186

merged 2 commits into from Oct 23, 2017

Conversation

jensens
Copy link
Sponsor Member

@jensens jensens commented Oct 23, 2017

…ame.test_loginAndLogoutSSO

@jensens jensens requested a review from pbauer October 23, 2017 11:56
@jensens
Copy link
Sponsor Member Author

jensens commented Oct 23, 2017

PR job would not go green, since there is a different issue left on 5.2 (iow: the last one)

@mauritsvanrees mauritsvanrees merged commit ff5be61 into master Oct 23, 2017
@mauritsvanrees mauritsvanrees deleted the sso-test-issue-z4 branch October 23, 2017 16:44
@mauritsvanrees
Copy link
Sponsor Member

Somehow this change did not get picked up by mr.roboto: no fake commit was done on coredev 5.2. I have started the Plone 5.2 Python 2.7 branch myself now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mauritsvanrees mauritsvanrees mauritsvanrees approved these changes

@pbauer pbauer Awaiting requested review from pbauer

Assignees
No one assigned
Labels
02 type: regression 23 status: testing
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jensens @mauritsvanrees