Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Register the ExceptionView for the unspecific zope.interface.Interface, to plone.rest #2282

Merged
merged 1 commit into from Jan 31, 2018

Conversation

thet
Copy link
Member

@thet thet commented Jan 30, 2018

adapters for requests providing a interface like plone.rest.interfaces.IAPIRequest. This one isn't a browser layer, and without this fix the ExceptionView would be registered for the base IBrowserLayer.
Before, there was a exception handling skin script, which could be overloaded by plone.rest.

Copy link
Sponsor Member

@mauritsvanrees mauritsvanrees left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have not tried it, but it seems okay.

…terface`` for easier overloading.

Fixes a problem, where plone.rest couldn't overload the ExceptionView with an adapter bound to ``plone.rest.interfaces.IAPIRequest``.
@thet thet merged commit f1d4305 into master Jan 31, 2018
@thet thet deleted the thet-exceptionview branch January 31, 2018 14:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants