Remove checkid script [5.2] #2583
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ck_id. No code changes yet, so this will need to be fixed. This just makes it easier to see what has changed compared with the original script.
Mostly: use context instead of container.
This used to be done automatically when it was still a skin script.
Mostly less indentation.
This took up half of the function. This had try/except Unauthorized a couple of times, which will likely not be raised now that it is no longer a skin script. But for safety we call _check_for_collision with a try/except Unauthorized.
Happens in basic plone.app.content tests.
….check_id function.
We no longer test the proxy roles, because we no longer have nor need the check_id.py.metadata file.
|
Manually merged to master to fix conflicts. Some Python 3 fixes had been done on master and I took them over. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #2582. Test together with others.