Remove quick installer code [6.0] #3189
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With the Products.CMFQuickInstallerTool package gone,
the bare bones fallback in this file did not work correctly.
You get an error like this when viewing the Plone Site in the ZMI,
or even just loading the root ZMI:
```
2020-04-24 23:29:39,113 ERROR [ZODB.Connection:809][waitress] Couldn't load state for Products.CMFPlone.Portal.PloneSite 0x9f8a
Traceback (most recent call last):
File "/Users/maurits/shared-eggs/cp37m/ZODB-5.5.1-py3.7.egg/ZODB/Connection.py", line 795, in setstate
self._reader.setGhostState(obj, p)
File "/Users/maurits/shared-eggs/cp37m/ZODB-5.5.1-py3.7.egg/ZODB/serialize.py", line 637, in setGhostState
state = self.getState(pickle)
File "/Users/maurits/shared-eggs/cp37m/ZODB-5.5.1-py3.7.egg/ZODB/serialize.py", line 630, in getState
return unpickler.load()
File "/Users/maurits/shared-eggs/cp37m/ZODB-5.5.1-py3.7.egg/ZODB/serialize.py", line 492, in _persistent_load
return self.load_persistent(*reference)
File "/Users/maurits/shared-eggs/cp37m/ZODB-5.5.1-py3.7.egg/ZODB/serialize.py", line 535, in load_persistent
self._cache.new_ghost(oid, obj)
TypeError: Cache values must be persistent objects.
```
I am creating an alias in plone.app.upgrade.
These were already copied to controlpanel/tests/ and adapted.
You cannot upgrade a Plone 4.0 or 5.1 site to 5.2 or higher when you are on Python 3. You must first migrate to 5.2 with Python 2.7. Also, this avoids a test failure on 6.0 because the 5.0alpha upgrade calls qi.isProductInstalled, which has been removed.
|
@jenkins-plone-org please run jobs |
ale-rt
approved these changes
Oct 2, 2020
|
I don't know why the tests fail. Maybe the other package merges were needed anyway, or it was too crowded on Jenkins. The other PRs are merged now. Let's try again. I have started the jobs manually. |
|
Jenkins keeps having the same test failures. This is on Plone 6.0 with Python 3.6, 3.7 and 3.8. Locally, with 3.8, all is fine.
Does anyone know what causes this? |
|
I am trying it with a slightly cleaned up coredev in plone/buildout.coredev#683 |
|
The coredev PR with this branch worked. I will merge both. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of PLIP #1775.
I think this can be tested and merged on its own.
Maybe the related
plone.app.upgradebranch is needed.