Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix dependencies #5

Merged
merged 3 commits into from Jul 9, 2018
Merged

Fix dependencies #5

merged 3 commits into from Jul 9, 2018

Conversation

gforcada
Copy link
Sponsor Contributor

@gforcada gforcada commented Jul 8, 2018

@davisagli in 2009 you introduced the AccessControl import, to avoid a circular import: 67e376a

Could we assume that this is no longer the case? 馃槄

Let's see what Jenkins says.

This is the first package being cleaned up with z3c.dependencychecker, actually it needs a pull request pending to be merged (reinout/z3c.dependencychecker#90) to work as expected.

It is part of PLIP plone/Products.CMFPlone#2448

@davisagli
Copy link
Sponsor Member

@gforcada I don't have any recollection about this. Jenkins passed, so go for it.

@gforcada gforcada merged commit 6269514 into master Jul 9, 2018
@gforcada gforcada deleted the fix-dependencies branch July 9, 2018 07:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants