This repository has been archived by the owner on Apr 10, 2023. It is now read-only.
Add userid information in reset mail #6
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ser password for a people having multiple users on a site.
|
I've also wondered "what was my userid again?", but I thought that requiring the user to remember the userid was a security measure .. |
|
Maybe a better implementation would be to include the userid only when the reset is done by a manager... |
|
Removed too wrong statement in mail when a manager has reset a password: the old password doesn't work anymore. |
|
Ok for me. @tisto what do you think ? |
|
Fine for me as well. We might also want the advice from members of the security team @davisagli @vangheem |
|
Hi @davisagli @vangheem @tisto, |
|
Looks good. That problem was annoying. |
vangheem
added a commit
that referenced
this pull request
Feb 9, 2015
Add userid information in reset mail
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is useful when an administrator resets a user password for a people having multiple accounts on a site.