Skip to content

Commit

Permalink
Merge pull request #15 from plone/bugfix-13853-selected-items-not-che…
Browse files Browse the repository at this point in the history
…cked

Bugfix 13853 selected items not checked
  • Loading branch information
esteele committed Apr 5, 2014
2 parents 59fb3f6 + c8e3a5b commit ff5f693
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 2 deletions.
4 changes: 3 additions & 1 deletion docs/CHANGES.txt
Expand Up @@ -4,7 +4,9 @@ Changelog
2.5.1 (unreleased)
------------------

- Nothing changed yet.
- Use foward compatable test for checked items with jQuery >=1.7
fixes https://dev.plone.org/ticket/13853
[arterrey]


2.5.0 (2014-02-23)
Expand Down
Expand Up @@ -426,7 +426,7 @@ jQuery(function(jq) {
uid_selector = "input[name='" + fieldname + ":list']",
current = jq(uid_selector), // the widget in the form
current_uids = current.map(function () {
if (jq(this).attr('checked') === true) {
if (this.checked === true) {
return jq(this).attr('value');
}
return null;
Expand Down

1 comment on commit ff5f693

@mister-roboto
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TESTS FAILED
Mr.Roboto url : http://jenkins.plone.org/roboto/get_info?push=d9195f73232b434d9a755011b28fb0f7
[FAILURE] kgs-archetypes.referencebrowserwidget-plone-4.2-python-2.6 kgs
[SUCCESS] kgs-archetypes.referencebrowserwidget-plone-4.2-python-2.7 kgs
[SUCCESS] kgs-archetypes.referencebrowserwidget-plone-4.3-python-2.6 kgs
[SUCCESS] kgs-archetypes.referencebrowserwidget-plone-4.3-python-2.7 kgs
[FAILURE] kgs-archetypes.referencebrowserwidget-plone-5.0-python-2.7 kgs

Please sign in to comment.