Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactore docs and fix some issues #329

Merged
merged 5 commits into from Oct 22, 2018
Merged

Refactore docs and fix some issues #329

merged 5 commits into from Oct 22, 2018

Conversation

MrTango
Copy link
Contributor

@MrTango MrTango commented Oct 18, 2018

No description provided.

@MrTango MrTango requested a review from svx October 18, 2018 16:00
@MrTango
Copy link
Contributor Author

MrTango commented Oct 18, 2018

@svx i tried to fix some issues and reorganized the content a bit.
I hope you are ok with my toctree usage. I want to avoid, that we have to update to much, everytime a new template is added.

docs/index.rst Show resolved Hide resolved
docs/index.rst Outdated

Add-ons created with ``bobtemplates.plone`` are tested to work in Plone 4.3.x and Plone 5.
Addon's created with ``bobtemplates.plone`` are tested to work in Plone 4.3.x and Plone 5.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We use add-on

`Title <http://link>`_
============
content_type
============
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Content Type, this is a header :)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

but in this case it's the name of the template, that's why i wouldn't use a different way of writing here.
I also use it to gerate the list of templates and they should have the correct names.
On other places I'll try to take this into account. thx

@@ -0,0 +1,22 @@
=====
addon
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add-on


.. topic:: Description

Creating an addon package and extending it with subtemplates.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add-on

Creating a Plone theme inside a package
=======================================
=====
theme
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Theme it is here used in a header


.. topic:: Description

Adding a theme to an existing addon package.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add-on :)

@@ -0,0 +1,34 @@
=================
theme_barceloneta
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same here, you use it in a heading, so it should be Theme Barceloneta, always remember these are docs, not code, even if we preach docs as code, this does not mean we write docs like we write code :)


.. topic:: Description

Adding a barceloneta theme to an existing addon package.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add-on


With this ``subtemplate``, you can add a Plone theme to a Plone package.

First create a Plone Addon Package:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add-on


First create a Plone Addon Package:

.. code-block:: sh
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please use .. code-block:: shell

This is also written in our styleguide -> https://docs.plone.org/about/contributing/rst-styleguide.html :)


then change into the created folder ``plonetheme.blacksea`` and your theme:

.. code-block:: sh
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same here: shell

Adding a vocabulary
===================
==========
vocabulary
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Vocabulary


.. topic:: Description

Adding a vocabulary to an existing addon package.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add-on

Create Plone buildout package
=============================
========
buildout
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Buildout

Creating a Plone theme package
==============================
=============
theme_package
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Theme Package

@svx
Copy link
Member

svx commented Oct 18, 2018

Please, please do not use more than one toctree, we are checking for multiple toctrees and tests are setup so that they fail if we detect more than one.

There is almost never a reason to use more than one, by using more than one you make your docs structure more complicated than it has to be and also multiple toctress are not playing nice which each other, we had that in the training docs and it was "hell" to solve, it took me almost a week and other people had already given up on that.

One common tip for structure docs, think "easy" and "flat". This is not code. Think who your audience is.

I went now 2 times of the whole bobtemplates docs, and there is serious no reason to use more than one toc and also as soon as I have one evening where I bored I will restructure the whole docs of this repo, if that is ok with everyone.

@MrTango
Copy link
Contributor Author

MrTango commented Oct 19, 2018

Thx for your advice. I thought with the second doctree we can solve the problem of having to update the docs on multible places, when ever we add a template. But if that makes trouble, I'll change it to normal a list of links. That means I can also change the writing of the headings as you suggested.

About restructuring the docs, maybe we can do it together.
I'm open for a hangout, to go over it.
That could be a good start, for more optimizations we would like to have in the central docs too, so let's try it out togerther on this smaller package ;).

@MrTango
Copy link
Contributor Author

MrTango commented Oct 19, 2018

Ok I've updated the docs again. Fell free to review it again.
Otherwise I'll merge it later, as it is an improvement anyway.

@MrTango MrTango merged commit a29167f into master Oct 22, 2018
@loechel loechel deleted the MrTango-refacture-docs branch November 6, 2018 03:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants