New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace future with six #85
Conversation
@petschki thanks for creating this Pull Request and helping to improve Plone! TL;DR: Finish pushing changes, pass all other checks, then paste a comment:
To ensure that these changes do not break other parts of Plone, the Plone test suite matrix needs to pass, but it takes 30-60 min. Other CI checks are usually much faster and the Plone Jenkins resources are limited, so when done pushing changes and all other checks pass either start all Jenkins PR jobs yourself, or simply add the comment above in this PR to start all the jobs automatically. Happy hacking! |
@jenkins-plone-org please run jobs |
1 similar comment
@jenkins-plone-org please run jobs |
jenkins jobs are green, but I do not really know why the tox/pytest setup doesn't work on gha ... @davisagli maybe you have some idea here? |
@jenkins-plone-org please run jobs |
@petschki It looks like the tests have a dependency on https://pypi.org/project/py/ which used to be a dependency of pytest, but now needs to be required explicitly, or replaced |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, can be merged when green.
I would also be fine with dropping 3.5 and 3.6 as these are end of life. Maybe 2.7 and 3.7 as well, dropping Plone 5.2 support, but that can be done when someone wants to clean up this package, removing Py 2 code.
But if it is not too much trouble, we can of course keep any old Python versions.
441705c
to
5e5c939
Compare
@jenkins-plone-org please run jobs |
@jenkins-plone-org please run jobs |
This will be a new test dependency for diazo. See plone/diazo#85
The Jenkins Plone 6 jobs failed because of a missing version pin for Is Meanwhile on Jenkins 5.2 3.8 passes, but 2.7 and 3.7 fail:
As I wrote, it could be an option to target this at Plone 6 only. |
This is fixed. While pytest gives a warning when returning the testsuite in I've pinned the |
All green, I merge. |
Thanks! |
see https://community.plone.org/t/plone-still-depends-on-the-future-python2-3-python-egg/15779