New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
https://github.com/collective/bobtemplates.plone #193
Comments
Big 👍 as for which version, @tisto has been doing some work lately targeted at Plone 5 so I would say that we most probably only want to start talking about it on Plone 5 and keep the zopeskel/templer mess on plone 4 |
This is more urgent than we may have thought. There is some nasty On Fri, Feb 6, 2015 at 8:02 AM, sven notifications@github.com wrote:
|
How far back is mr.bob and bobtemplates compatible? Does it work on 4.0-4.2? If so, I say we change quickly. If not, we have an issue... |
I would gladly move bobtemplates.plone to the plone-repo. Do I need to get the permission for all the other commiters? Regarding versions I think it should be in Plone 4 and 5 since it supports both. I never tried using an addon created with bobtemplates.plone in anything older than Plone 4.3 but will do so and I don't think there is anything in it that prevents the addons to work. Although the buildout that comes with the addons is for now allways using Plone 4.3.4. |
@pbauer , only on Cedric (https://github.com/cedricmessiant) I'm not sure he has already signed a Contributor Agreement (he should anyway ;-) so he'd be the one to ask. |
I asked him |
And I just tried an addon with Plone 4.2.7, 4.1.6 and saw no problems. I could not get it to run in 4.0.10 and was too lazy to spend time on that since I think that is acceptable. |
OK, assuming Cedric can be contacted so we can pull the whole bobtemplates doc into documentation proper, that would mean (just listing it here, not saying I'll write it within the next few days.....)
All doable, just needs some love. |
just let me know when I can change and I will do it |
@cedricmessiant confirmed that he already signed over his soul to Plone. I created https://github.com/plone/bobtemplates.plone and will move https://github.com/collective/bobtemplates.plone there |
OK I see the new repo in core :) I will work on this during the next days to make sure it will be in the next docs release which will be in around two weeks |
Then some of the admins should also add @cedricmessiant to the Plone org repo. |
He is already a member |
hmm, I see only 'collective' in his profile. But OK, this is getting offtopic |
Me too but if I check the member of the organization it shows me that he is a member |
Thanks, Philip. I think you've done adequate diligence. If someone needs On Sat, Feb 7, 2015 at 11:19 AM, Philip Bauer notifications@github.com
|
New branch: https://github.com/plone/documentation/tree/bobtemplates_p4 @polyester: I did not changed https://github.com/plone/documentation/blob/master/develop/addons/dexterity.rst, since we can't do that with bobtemplates, yet |
Removing paster parts form the docs is currently way more work, the whole section /develop is full of it. |
just to be sure I will ask one last time, is it OK with everyone that I start to remove all paster/zopeskel parts from the 5 branch ? |
🙏 👏 🎆 |
Yes please! :) |
Ok I will refactor and update the branch like: we are pulling bobtemplates to /develop and reference to it. For all existing paster docs in the 4 branch, we will add that paster is depreciated and also will link/refence to bobtemplates. For Plone 5 docs, we will rip paster out :) Cool with everyone ? |
PR is out ! The only thing what is missing now, is updating the docs of diazo and dexterity, this has to be done in their repos since we just fetch them. If someone wants to do that, but want help for the docs part of it, ping me! To give a bit motivation, this is the last bit what is missing before we can push a huge, I mean it, a HUGE update to docs.plone.org, including pre-alpha Plone 5 docs and nightly builds of all our docs to preview.docs.plone.org. |
any takers for diazo and dexterity ? |
Unfortunately (well, not really, but bobtemplates would have been more current), Mikel Larreategi (@erral) created a nice diazo5-barceloneta based codeskel just a week or so ago, see https://github.com/codesyntax/CodeSkel Maybe that can be more or less easily re-used as a bobtemplates one? |
I know but I was more referring to: The only thing what is missing now, is updating the docs of diazo and dexterity, this has to be done in their repos since we just fetch them So the docs/readmes in the github repos of diazo and dexterity are needing updates, because there are still talking about paster, this should be changed to mr.bob templates if that is possible of course, otherwise we still have paster in the docs. :) |
yup, I was trying to avoid having a new paster reference in the "theming" docs, because @erral's one is quite nice ;-) |
OK maybe that is a bit harsh, but we will not do that by all means :), it was so much work removing paster out of the docs and we are almost there, only diazo and dexterity are left to do. There will be NO paster reference in the docs of Plone 5 :) |
I guess it wouldn't be too hard to refactor the ZopeSkel template to mr.bob. The main question would be how do we handle that inside bobtemplates.plone? Theming differs a lot between Plone 4 and 5. I'm not sure if we really want to put all that into one project/template. Maybe we should factor out the theming part into a separate template. |
Now we have Basic, Dexterity and Theme. So then we would have Basic, Dexterity, Theme, P5_Theme. Seems to make sense, although I can see why separating out is also an option. Still, this is what a lot of people will want: give me something based on Barceloneta so I have a best-practice start. |
This is more an internal problem. If we have four different things within the same template structure, we end up with lots of combined if/else structures that are a nightmare to maintain and test. I worked hard on removing those structures and make bobtemplates.plone testable. I fully agree that we want a Plone 5 Theme option, we just have to make sure we do it in a testable and maintainable way. We need to have a look at the P5 skeleton to decide what's the best way to go. |
I have no problem on merging it to bobtemplates.plone; I created it as a Anyway, I can work on it, but I am currently on holidays, so i can do it On Mon, Aug 10, 2015 at 4:46 PM, Timo Stollenwerk notifications@github.com
Mikel Larreategi CodeSyntax |
That's largely done, I only see very few references to zopeskel, so maybe it would be best to open tickets for each of them specifically. Closing! |
should we add this to the docs ?
if so to which version ?
The text was updated successfully, but these errors were encountered: