Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

plone.directives (grok alert?) #434

Closed
fulv opened this issue Nov 17, 2015 · 3 comments
Closed

plone.directives (grok alert?) #434

fulv opened this issue Nov 17, 2015 · 3 comments

Comments

@fulv
Copy link
Member

fulv commented Nov 17, 2015

http://docs.plone.org/develop/plone/forms/schemas.html#multi-choice-example

This example does a from plone.directives import form, but plone.directives.form depends on five.grok.

My question: is five.grok (and all the grokcore namespace packages) acceptable because it's not the real Grok, or did we miss a big chunk of degrokkification?

(See #296)

@davisagli
Copy link
Sponsor Member

This needs to be degrokkified.

In this case it's as simple as importing Schema from plone.supermodel.model instead of plone.directives.form

@fulv
Copy link
Member Author

fulv commented Nov 17, 2015

What about form.widget?

@fulv
Copy link
Member Author

fulv commented Nov 17, 2015

I'm guessing from plone.autoform import directives as form?

fulv added a commit that referenced this issue Nov 17, 2015
@svx svx closed this as completed in #435 Nov 18, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants