Barceloneta based Classic UI theme

[petschki]

No description provided.

[netlify]

✅ Deploy Preview for 6-docs-plone-org ready!

Name	Link
🔨 Latest commit	63b3660
🔍 Latest deploy log	https://app.netlify.com/sites/6-docs-plone-org/deploys/64ae70754e125e0008dec427
😎 Deploy Preview	https://deploy-preview-1516--6-docs-plone-org.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

---

To edit notification comments on pull requests, go to your Netlify site configuration.

[gogobd]

Hi, @petschki !

• Maybe consider mentioning the version of npm you would recommend and that the generated theme addon needs to be installen (via Plone Panel).

Please mention that the file that should contain the font definitions is _variables.scss. I used a font other than the default font just to be able to see the change immediately:

$font-family-sans-serif:                    "Papyrus", "Fantasy";
$font-family-condensed:                     "Papyrus", "Fantasy"; //just on toolbar
$font-family-serif:                         "Papyrus", "Fantasy";

• This $enabled-rounded: false; switch didn't work.

• I was assuming that the changes mentioned in "Maps" would go into maps.scss, it's not mentioned but at the same time quite obvious i.e. most likely everyone's first guess.

[stevepiercy]

I just did a merge commit to bring it inline with main due to the failing docs test. We will see if it passes now.

[stevepiercy]

Mostly a bunch of MyST, style guide, and English syntax and grammar fixes.

Would you please take a look at moving Node.js and nvm installation to the top of the page after the introduction, and see if there is something that can be reused from existing installation documentation? Thank you!

[petschki]

@stevepiercy thank you for your review. I've changed the doc and put the Node.js information at the top with a link to Install Plone from its packages. There I've found details on installing python, node, nvm ...

[stevepiercy]

I decided it would be easier to push a commit 63b3660 with my suggestions than go through a formal review. Feel free to change them. Thank you for your contribution. This is super helpful.

[stevepiercy]

Suggested change

	## Create a Classic UI theme addon package
	## Create a Classic UI theme add-on package

[petschki]

This is good to merge for me 🤗 @gogobd wanted to take a second look over this.