Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adds backend widgets content fixing #1307 #1552

Merged
merged 29 commits into from
Oct 23, 2023
Merged

Adds backend widgets content fixing #1307 #1552

merged 29 commits into from
Oct 23, 2023

Conversation

rber474
Copy link
Member

@rber474 rber474 commented Oct 22, 2023

No description provided.

@netlify
Copy link

netlify bot commented Oct 22, 2023 •
edited

✅ Deploy Preview for 6-docs-plone-org ready!

Name Link
🔨 Latest commit 4f5bd78
🔍 Latest deploy log https://app.netlify.com/sites/6-docs-plone-org/deploys/6536f91674d9190008c057a8
😎 Deploy Preview https://deploy-preview-1552--6-docs-plone-org.netlify.app/backend/widgets.html
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@rber474
Copy link
Member Author

rber474 commented Oct 22, 2023

Test failed because of the broken link https://52.demo.plone.org in install/index.md reported in issue #1553 and commented by @stevepiercy days ago in https://community.plone.org/t/5-2-demo-is-down/18059?u=rber474

@rber474 rber474 requested a review from fredvd October 22, 2023 18:30
@rber474 rber474 linked an issue Oct 22, 2023 that may be closed by this pull request
Backend > Widgets needs content #1307
Closed
2 tasks
@stevepiercy
Copy link
Contributor

We can ignore the failed link until a decision is made about what to do with that site.

@stevepiercy
Clean up original version.
16718d1 
- Change from passive to active voice.
- Address the reader directly as "you".
- Clean up link references.
- One sentence per line.
- Clean up MyST syntax for inline literals and code blocks.
- Remove Unicode text markers for Python 3 code.
- Use double instead of single quotes for Python strings and other bits.
stevepiercy
stevepiercy requested changes Oct 22, 2023
View reviewed changes
Copy link
Contributor

@stevepiercy stevepiercy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is excellent. I have a couple of comments and questions about the code examples. Please have a look. Thank you!

docs/backend/widgets.md Outdated Show resolved Hide resolved
docs/backend/widgets.md Outdated Show resolved Hide resolved
docs/backend/widgets.md Outdated Show resolved Hide resolved
stevepiercy
stevepiercy requested changes Oct 23, 2023
View reviewed changes
Copy link
Contributor

@stevepiercy stevepiercy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove the three submodules. We only update them when deploying the docs.

docs/backend/widgets.md Outdated Show resolved Hide resolved
docs/backend/widgets.md Outdated Show resolved Hide resolved
@rber474
Copy link
Member Author

rber474 commented Oct 23, 2023

I am not sure if deleting the submodules won't be remove them in the main branch. Please, review that @stevepiercy

stevepiercy
stevepiercy requested changes Oct 23, 2023
View reviewed changes
docs/backend/widgets.md Show resolved Hide resolved
docs/backend/widgets.md Outdated Show resolved Hide resolved
docs/backend/widgets.md Outdated Show resolved Hide resolved
@stevepiercy
Copy link
Contributor

I am not sure if deleting the submodules won't be remove them in the main branch. Please, review that @stevepiercy

I meant to remove the commits that updated the submodule tips. Sorry for the confusion. I think because this PR comes from your fork, things are different from what I understand. Go ahead and restore the submodule tips to the latest from documentation/6.0. Thank you!

rber474 and others added 13 commits October 23, 2023 12:27
@rber474 @stevepiercy
Update docs/backend/widgets.md
51ca09f 
Co-authored-by: Steve Piercy <web@stevepiercy.com>
@rber474 @stevepiercy
Update docs/backend/widgets.md
8cf69bb 
Co-authored-by: Steve Piercy <web@stevepiercy.com>
@rber474
fix code-block syntax
621159a
@rber474
Adds backend widgets content fixing plone#1307
3af0eee
@stevepiercy @rber474
Clean up original version.
86c851c 
- Change from passive to active voice.
- Address the reader directly as "you".
- Clean up link references.
- One sentence per line.
- Clean up MyST syntax for inline literals and code blocks.
- Remove Unicode text markers for Python 3 code.
- Use double instead of single quotes for Python strings and other bits.
@rber474
sync branch with 6.0
054e9e1
@rber474
apply changes proposed by @stevepiercy
829ea20
@rber474
removes submodles
65fa93d
@rber474 @stevepiercy
Update docs/backend/widgets.md
b1eef8f 
Co-authored-by: Steve Piercy <web@stevepiercy.com>
@rber474 @stevepiercy
Update docs/backend/widgets.md
9741c2d 
Co-authored-by: Steve Piercy <web@stevepiercy.com>
@rber474
fix code-block syntax
9ba46af
@rber474
Merge branch 'widgets' of github.com:rber474/plone.documentation into…
64888b0 
… widgets
@rber474
Revert "removes submodles"
08067d3 
This reverts commit 74b127b.
@rber474
Copy link
Member Author

rber474 commented Oct 23, 2023

@stevepiercy Thanks for your patient! I think everything is fixed now.

stevepiercy
stevepiercy requested changes Oct 23, 2023
View reviewed changes
Copy link
Contributor

@stevepiercy stevepiercy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a little tidying up and it's good to go. Thank you!

docs/backend/widgets.md Outdated Show resolved Hide resolved
docs/backend/widgets.md Outdated Show resolved Hide resolved
docs/backend/widgets.md Outdated Show resolved Hide resolved
docs/backend/widgets.md Outdated Show resolved Hide resolved
docs/backend/widgets.md Outdated Show resolved Hide resolved
docs/backend/widgets.md Outdated Show resolved Hide resolved
rber474 and others added 8 commits October 23, 2023 23:26
@rber474 @stevepiercy
Actualizar widgets.md
8ec9aee 
Co-authored-by: Steve Piercy <web@stevepiercy.com>
@rber474 @stevepiercy
Actualizar widgets.md
0c52f0a 
Co-authored-by: Steve Piercy <web@stevepiercy.com>
@rber474 @stevepiercy
Actualizar widgets.md
7516697 
Co-authored-by: Steve Piercy <web@stevepiercy.com>
@rber474 @stevepiercy
Actualizar widgets.md
151f0e1 
Co-authored-by: Steve Piercy <web@stevepiercy.com>
@rber474 @stevepiercy
Actualizar widgets.md
6bbf7dc 
Co-authored-by: Steve Piercy <web@stevepiercy.com>
@rber474 @stevepiercy
Actualizar widgets.md
fdfe1ba 
Co-authored-by: Steve Piercy <web@stevepiercy.com>
@stevepiercy
Trim extra white space from code samples.
1d8d822
@stevepiercy
Update submodule tips to current ones.
4f5bd78
@stevepiercy
Copy link
Contributor

OK, I cleaned up some extra white spaces and updated the submodule tips to the current ones, instead of deleting them, so that they matched those in 6.0 and dropped off this PR. Let's see what the CI says.

@stevepiercy
Copy link
Contributor

The two broken links are known. I notified evee of their bad secure certificate yesterday, and we are waiting for someone to either bring up or take down the 5.2 demo.

@stevepiercy stevepiercy merged commit d72e5da into plone:6.0 Oct 23, 2023
4 of 5 checks passed
@stevepiercy
Copy link
Contributor

Thank you!

@rber474 rber474 deleted the widgets branch October 24, 2023 07:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stevepiercy stevepiercy stevepiercy approved these changes

@fredvd fredvd Awaiting requested review from fredvd

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Backend > Widgets needs content
2 participants
@rber474 @stevepiercy