-
-
Notifications
You must be signed in to change notification settings - Fork 154
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add plone.autoform
documentation for classic UI
#1571
Conversation
✅ Deploy Preview for 6-docs-plone-org ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
3ffc66f
to
edc9ae7
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Mostly a bunch of style guide suggestions.
- Please use one line per sentence. Documentation is not code.
- Dedent code examples to avoid horizontal scrolling.
- Some missing inline literals.
Also I agree with and defer to @MrTango suggestions for where topics belong. I would replace the content with reference links to the authoritative content. That might require adding references and targets in MyST syntax.
For example:
```{seealso}
{ref}`Referenced section <target>`
```
and in the target section:
```
(target)=
```
b35f7d2
to
bd95219
Compare
c9ebffa
to
6a56c28
Compare
I've also removed this part:
|
8661e86
to
8fd6657
Compare
8fd6657
to
8c26e91
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we need the u
in u"value"
in Plone 6? I would prefer to remove all these instances, if not needed.
Otherwise I pushed a few commits to tidy this up and push it over the finish line. It requires a core contributor or maintainer to review its technical accuracy.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very important! LGTM, just one question.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. One more pass from @jensens, or anyone else, and we can merge. Thank you!
i can't find the default value info, you want to remove, elsewhere. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Except the default value part you want to remove, LGTM. feel free to merge
yes, he said that what he want's to remove is described elsewhere, but i could not find it. |
Sorry for the confusion. I've only de-duplicated the "default value hint" in |
@petschki thanks for the clarification. I'll merge when it is green. Thank you! |
There was a broken link to the TinyMCE 4 to 5 upgrade guide. I also created a new issue to upgrade to the latest version TinyMCE 7, as v5 is EOL. plone/Products.CMFPlone#3936 |
Put
plone.autoform
documentation to the designated places.