-
-
Notifications
You must be signed in to change notification settings - Fork 154
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove duplicate contributing navigation #1603
Conversation
stevepiercy
commented
Jan 14, 2024
- Fixes Contributing to projects has duplicate navigation #1582
✅ Deploy Preview for 6-docs-plone-org ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
The failing workflow |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Possibly another use case for https://documatt.com/sphinx-reredirects/index.html (but I can't tell without trying whether it supports including the redirect pages in tables of contents)
But, LGTM as is too.
We need to keep the milestone files in place to avoid Sphinx warnings, and when built they will get clobbered by sphinx-reredirects. This is OK. When I deleted the milestone files, Sphinx complained, for example:
We need the toctree entry, so we need the milestone files in source. Fixed in 1d80cc0 |
Requested in Discord of AI Team to add four 301 permanent redirects. Right now they return 200, then redirect, which is not great for SEO. rewrite ^/contributing/plone-api.html$ https://6.docs.plone.org/plone.api/contribute/index.html permanent;
rewrite ^/contributing/plone-restapi.html$ https://6.docs.plone.org/plone.restapi/docs/source/contributing/index.html permanent;
rewrite ^/contributing/volto.html$ https://6.docs.plone.org/volto/contributing/index.html permanent;
rewrite ^/install/install-from-packages.html$ https://6.docs.plone.org/install/create-project.html permanent; |
done |