Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove duplicate contributing navigation #1603

Merged
merged 3 commits into from
Jan 15, 2024

Conversation

stevepiercy
Copy link
Contributor

@stevepiercy stevepiercy self-assigned this Jan 14, 2024
Copy link

netlify bot commented Jan 14, 2024

Deploy Preview for 6-docs-plone-org ready!

Name Link
🔨 Latest commit 7f7ef7f
🔍 Latest deploy log https://app.netlify.com/sites/6-docs-plone-org/deploys/65a595de3428630008df7a92
😎 Deploy Preview https://deploy-preview-1603--6-docs-plone-org.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@stevepiercy
Copy link
Contributor Author

The failing workflow Test is due to a new version of Vale getting released. I have a temporary workaround in another PR by pinning it to 2.30.0, and created an issue to fix it, when someone has some time.

davisagli
davisagli previously approved these changes Jan 15, 2024
Copy link
Sponsor Member

@davisagli davisagli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Possibly another use case for https://documatt.com/sphinx-reredirects/index.html (but I can't tell without trying whether it supports including the redirect pages in tables of contents)

But, LGTM as is too.

@stevepiercy
Copy link
Contributor Author

We need to keep the milestone files in place to avoid Sphinx warnings, and when built they will get clobbered by sphinx-reredirects. This is OK. When I deleted the milestone files, Sphinx complained, for example:

/Users/stevepiercy/projects/Plone/documentation/docs/contributing/index.md:175: WARNING: toctree contains reference to nonexisting document 'contributing/plone-api'

We need the toctree entry, so we need the milestone files in source. Fixed in 1d80cc0

davisagli
davisagli previously approved these changes Jan 15, 2024
@stevepiercy stevepiercy merged commit df5c0cc into 6.0 Jan 15, 2024
6 checks passed
@stevepiercy stevepiercy deleted the remove-duplicate-contributing-navigation branch January 15, 2024 20:41
@stevepiercy
Copy link
Contributor Author

stevepiercy commented Jan 15, 2024

Requested in Discord of AI Team to add four 301 permanent redirects. Right now they return 200, then redirect, which is not great for SEO.

@polyester @fredvd

rewrite ^/contributing/plone-api.html$ https://6.docs.plone.org/plone.api/contribute/index.html permanent;
rewrite ^/contributing/plone-restapi.html$ https://6.docs.plone.org/plone.restapi/docs/source/contributing/index.html permanent;
rewrite ^/contributing/volto.html$ https://6.docs.plone.org/volto/contributing/index.html permanent;
rewrite ^/install/install-from-packages.html$ https://6.docs.plone.org/install/create-project.html permanent;

@polyester
Copy link
Sponsor Member

done

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Contributing to projects has duplicate navigation
3 participants