Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do3cc upgrade z3cform #508

Merged
merged 4 commits into from Mar 2, 2016
Merged

Do3cc upgrade z3cform #508

merged 4 commits into from Mar 2, 2016

Conversation

do3cc
Copy link
Member

@do3cc do3cc commented Jan 29, 2016

Still unfinished but better than nothing.
Also, what got documented is right. I think ;-)

Table with new and old properties is complete, TBDs are currently being worked
on and need to be updated maybe.
@do3cc
Copy link
Member Author

do3cc commented Jan 29, 2016

Aww, damn, git merge does work better for code than for docs, git does not understand that I created Control Panel Changes docs in september and somebody did the same in november. So don't merge, I need to check this manually

@do3cc
Copy link
Member Author

do3cc commented Mar 2, 2016

This PR is not WIP any more
still need more docs though

@svx
Copy link
Member

svx commented Mar 2, 2016

@do3cc do you mean it is OK to merge now or you want to wait and add more docs first ?

@do3cc
Copy link
Member Author

do3cc commented Mar 2, 2016

Hi @svx I'd love to finish the documentation but I failed to do so since september. Since it is still a big improvement, I'm suggesting to merge it right now, because nobody looks for WIP pull requests when updating documentation

@svx
Copy link
Member

svx commented Mar 2, 2016

ok !

svx added a commit that referenced this pull request Mar 2, 2016
@svx svx merged commit 0be154e into 5.0 Mar 2, 2016
@svx svx deleted the do3cc-upgrade-z3cform branch March 2, 2016 07:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants