Skip to content

Commit

Permalink
Default transactions strategies need to start a transaction even for …
Browse files Browse the repository at this point in the history
…reads
  • Loading branch information
vangheem committed May 5, 2017
1 parent 5dc20d1 commit 4a8a876
Show file tree
Hide file tree
Showing 3 changed files with 3 additions and 5 deletions.
3 changes: 2 additions & 1 deletion CHANGELOG.rst
@@ -1,7 +1,8 @@
1.0.0a18 (unreleased)
---------------------

- Nothing changed yet.
- Default transactions strategies need to start a transaction even for reads
[vangheem]


1.0.0a17 (2017-05-05)
Expand Down
2 changes: 1 addition & 1 deletion config.json
Expand Up @@ -2,7 +2,7 @@
"databases": [{
"db": {
"storage": "postgresql",
"transaction_strategy": "none",
"transaction_strategy": "merge",
"dsn": {
"scheme": "postgres",
"dbname": "guillotina",
Expand Down
3 changes: 0 additions & 3 deletions guillotina/db/strategies/simple.py
Expand Up @@ -14,9 +14,6 @@ class SimpleStrategy(BaseStrategy):
'''

async def tpc_begin(self):
if not self.writable_transaction:
return

await self._storage.start_transaction(self._transaction)
tid = await self._storage.get_next_tid(self._transaction)
if tid is not None:
Expand Down

0 comments on commit 4a8a876

Please sign in to comment.