Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[5.x] Add prometheus metrics to pg and redis operations #1005

Merged
merged 8 commits into from Sep 22, 2020
Merged

[5.x] Add prometheus metrics to pg and redis operations #1005

merged 8 commits into from Sep 22, 2020

Conversation

vangheem
Copy link
Member

No description provided.

masipcat
masipcat reviewed Sep 22, 2020
View reviewed changes
Copy link
Contributor

@masipcat masipcat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The idea is to keep guillotina_prometheus to expose these metrics?

bloodbare
bloodbare approved these changes Sep 22, 2020
View reviewed changes
Copy link
Member

@bloodbare bloodbare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@vangheem
Copy link
Member Author

The idea is to keep guillotina_prometheus to expose these metrics?

Yes, or you can expose them yourself by implementing your own metrics endpoint.

@vangheem vangheem merged commit 3ebe744 into 5.x Sep 22, 2020
@vangheem vangheem deleted the 5-x-metrics branch September 22, 2020 16:34
@masipcat
Copy link
Contributor

No port for G6? I'd like to get this metrics!

masipcat pushed a commit that referenced this pull request Dec 1, 2020
@vangheem @masipcat
Add prometheus metrics to pg and redis operations (#1005)
126e16c
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bloodbare bloodbare bloodbare approved these changes

@masipcat masipcat masipcat approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@vangheem @masipcat @bloodbare