Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow plip implementers to provide an email address that is used for notifications. #87

Closed
tisto opened this issue Mar 2, 2015 · 4 comments · Fixed by #98
Closed

Allow plip implementers to provide an email address that is used for notifications. #87

tisto opened this issue Mar 2, 2015 · 4 comments · Fixed by #98
Assignees

Comments

@tisto
Copy link
Sponsor Member

tisto commented Mar 2, 2015

First, we could add the email addresses fo the PLIP implementer to jobs.yml. Later we could read them from the plip cfg so people can add/remove ppl themself.

@gforcada
Copy link
Sponsor Contributor

gforcada commented Mar 2, 2015

Sounds like a good idea, something like this?

[buildout]
extends = plipbase.cfg
email = my@email.org

I see that for example https://github.com/plone/buildout.coredev/blob/5.0/plips/plip10359-security-controlpanel.cfg has some comments at the top describing the PLIP itself, maybe we can just use that also?

# PLIP: https://dev.plone.org/ticket/10359
# github: https://github.com/plone/Products.CMFPlone/issues/216
# email: my@email.org
# description:
# Convert security control panel to use z3c.form
# Use registry configuration
# Move it to Products.CMFPlone

So that it's a bit easier to parse, and actually, if we get around to improve mr.roboto/jenkins we could ping back the build status on the github issue...

@tisto
Copy link
Sponsor Member Author

tisto commented Mar 2, 2015

@gforcada sounds good! A descriptive header should be a requirement anyways.

@gforcada
Copy link
Sponsor Contributor

Should we instead use the email of the one that runs the jenkins job just like the pull requests? It will make more sense IMHO.

I could create the PLIP cfg and add myself as the one to notify, but someone else could be the one working on it later on and it will still be me getting the notifications...

gforcada added a commit that referenced this issue Apr 5, 2015
Send an email to whoever started a PLIP job with the job result.

This works the same way as the pull request job.

Fixes: #87
@gforcada gforcada self-assigned this Apr 5, 2015
@gforcada
Copy link
Sponsor Contributor

gforcada commented Apr 5, 2015

I created a pull request for it: #98

@gforcada gforcada closed this as completed Apr 7, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants