Skip to content

Commit

Permalink
Merge 55d928a into 5107fd7
Browse files Browse the repository at this point in the history
  • Loading branch information
vincentfretin committed Aug 2, 2020
2 parents 5107fd7 + 55d928a commit 37b6880
Show file tree
Hide file tree
Showing 14 changed files with 43 additions and 29 deletions.
8 changes: 4 additions & 4 deletions mockup/js/ui/views/anchor.js
Expand Up @@ -33,23 +33,23 @@ define([
this.$el.attr('aria-label', this.options.title || this.options.tooltip || '');
_.each(this.extraClasses, function(klass) {
this.$el.addClass(klass);
});
}.bind(this));
}, this);
},
handleClick: function(e) {
e.preventDefault();
if (!this.$el.prop('disabled')) {
if (!this.$el.is('.disabled')) {
this.uiEventTrigger('click', this, e);
}
},
serializedModel: function() {
return _.extend({'icon': '', 'title': '', 'shortcut': ''}, this.options);
},
disable: function() {
this.$el.prop('disabled', true);
this.$el.addClass('disabled');
},
enable: function() {
this.$el.prop('disabled', false);
this.$el.removeClass('disabled');
}
});

Expand Down
6 changes: 3 additions & 3 deletions mockup/js/ui/views/button.js
Expand Up @@ -53,18 +53,18 @@ define([
},
handleClick: function(e) {
e.preventDefault();
if (!this.$el.prop('disabled')) {
if (!this.$el.is('.disabled')) {
this.uiEventTrigger('click', this, e);
}
},
serializedModel: function() {
return _.extend({'icon': '', 'title': ''}, this.options);
},
disable: function() {
this.$el.prop('disabled', true);
this.$el.addClass('disabled');
},
enable: function() {
this.$el.prop('disabled', false);
this.$el.removeClass('disabled');
}
});

Expand Down
4 changes: 4 additions & 0 deletions mockup/patterns/filemanager/pattern.filemanager.less
Expand Up @@ -57,6 +57,10 @@
min-width: 250px;
}
}
.alink.disabled {
cursor: @cursor-disabled;
.opacity(.65);
}
.input-group:extend(.input-group all){}
.input-group-addon:extend(.input-group-addon all){}
.input-group-btn:extend(.input-group-btn all){}
Expand Down
2 changes: 1 addition & 1 deletion mockup/patterns/querystring/pattern.js
Expand Up @@ -828,7 +828,7 @@ define([
$('[id$="sort_on"]', existingSortOn).val($(this).val());
});

self.$sortOn.append($('<option value="">No sorting</option>')); // default no sorting
self.$sortOn.append($('<option value="">' + _t('No sorting') + '</option>')); // default no sorting
for (var key in self.options['sortable_indexes']) { // jshint ignore:line
self.$sortOn.append(
$('<option/>')
Expand Down
Expand Up @@ -90,18 +90,13 @@
}

.lessvariables,
.patternoptionsuse {
.patternoptions {
.form{
padding-top: 15px;
clear: both;
}
}

.pat-resourceregistry .lessvariables .form {
padding-top: 10px;
clear: both;
}

.patternoptions {
.form-control-feedback {
top: 0;
Expand Down
20 changes: 10 additions & 10 deletions mockup/patterns/structure/js/actionmenu.js
@@ -1,18 +1,18 @@
define(['underscore'], function(_) {
define(['underscore', 'translate'], function(_, _t) {
'use strict';

var menuOptions = {
'openItem': {
'url': '#',
'title': 'Open',
'title': _t('Open'),
'category': 'button',
'iconCSS': 'glyphicon glyphicon-eye-open',
'css': '',
'modal': false
},
'editItem': {
'url': '#',
'title': 'Edit',
'title': _t('Edit'),
'category': 'button',
'iconCSS': 'glyphicon glyphicon-pencil',
'css': '',
Expand All @@ -22,7 +22,7 @@ define(['underscore'], function(_) {
'library': 'mockup-patterns-structure-url/js/actions',
'method': 'cutClicked',
'url': '#',
'title': 'Cut',
'title': _t('Cut'),
'category': 'dropdown',
'iconCSS': 'glyphicon glyphicon-scissors',
'css': '',
Expand All @@ -32,7 +32,7 @@ define(['underscore'], function(_) {
'library': 'mockup-patterns-structure-url/js/actions',
'method': 'copyClicked',
'url': '#',
'title': 'Copy',
'title': _t('Copy'),
'category': 'dropdown',
'iconCSS': 'glyphicon glyphicon-duplicate',
'css': '',
Expand All @@ -42,7 +42,7 @@ define(['underscore'], function(_) {
'library': 'mockup-patterns-structure-url/js/actions',
'method': 'pasteClicked',
'url': '#',
'title': 'Paste',
'title': _t('Paste'),
'category': 'dropdown',
'iconCSS': 'glyphicon glyphicon-open-file',
'css': '',
Expand All @@ -52,7 +52,7 @@ define(['underscore'], function(_) {
'library': 'mockup-patterns-structure-url/js/actions',
'method': 'moveTopClicked',
'url': '#',
'title': 'Move to top of folder',
'title': _t('Move to top of folder'),
'category': 'dropdown',
'iconCSS': 'glyphicon glyphicon-step-backward rright',
'css': '',
Expand All @@ -62,7 +62,7 @@ define(['underscore'], function(_) {
'library': 'mockup-patterns-structure-url/js/actions',
'method': 'moveBottomClicked',
'url': '#',
'title': 'Move to bottom of folder',
'title': _t('Move to bottom of folder'),
'category': 'dropdown',
'iconCSS': 'glyphicon glyphicon-step-backward rleft',
'css': '',
Expand All @@ -72,7 +72,7 @@ define(['underscore'], function(_) {
'library': 'mockup-patterns-structure-url/js/actions',
'method': 'setDefaultPageClicked',
'url': '#',
'title': 'Set as default page',
'title': _t('Set as default page'),
'category': 'dropdown',
'iconCSS': 'glyphicon glyphicon-ok-circle',
'css': '',
Expand All @@ -82,7 +82,7 @@ define(['underscore'], function(_) {
'library': 'mockup-patterns-structure-url/js/actions',
'method': 'selectAll',
'url': '#',
'title': 'Select all contained items',
'title': _t('Select all contained items'),
'category': 'dropdown',
'iconCSS': 'glyphicon glyphicon-check',
'css': '',
Expand Down
2 changes: 1 addition & 1 deletion mockup/patterns/structure/js/views/selectionwell.js
Expand Up @@ -9,7 +9,7 @@ define([
var WellView = PopoverView.extend({
className: 'popover selected-items',
title: _.template(
'<input type="text" class="filter" placeholder="Filter" />' +
'<input type="text" class="filter" placeholder="<%- _t("Filter") %>" />' +
'<a href="#" class=" remove-all">' +
'<span class="glyphicon glyphicon-remove-circle"></span> <%- _t("remove all") %></a>'
),
Expand Down
2 changes: 1 addition & 1 deletion mockup/patterns/structure/templates/actionmenu.xml
Expand Up @@ -18,7 +18,7 @@
aria-haspopup="true"
aria-expanded="true"
id="<%- id %>"
title="Actions">
title='<%- _t("Actions") %>'>
<span class="glyphicon glyphicon-cog"></span><span class="caret"></span>
</a>
<ul class="dropdown-menu pull-right" aria-labelledby="<%- id %>">
Expand Down
6 changes: 3 additions & 3 deletions mockup/patterns/upload/templates/preview.xml
@@ -1,5 +1,5 @@
<div class="row item form-inline">
<div class="col-md-1 action">
<div class="col-xs-2 action">
<button
type="button"
class="btn btn-danger btn-xs remove-item"
Expand All @@ -8,7 +8,7 @@
<span class="glyphicon glyphicon-remove"></span>
</button>
</div>
<div class="col-md-8 title">
<div class="col-xs-7 title">
<div class="dz-preview">
<div class="dz-details">
<div class="dz-filename"><span data-dz-name></span></div>
Expand All @@ -19,7 +19,7 @@
<span class="dz-upload" data-dz-uploadprogress></span>
</div>
</div>
<div class="col-md-3 info">
<div class="col-xs-3 info">
<div class="dz-size" data-dz-size></div>
<img data-dz-thumbnail />
</div>
Expand Down
4 changes: 4 additions & 0 deletions news/1000.bugfix
@@ -0,0 +1,4 @@
Fix filename overlapping the remove button in the Upload dialog.
This fixes https://github.com/plone/Products.CMFPlone/issues/2533 and
https://github.com/plone/plonetheme.barceloneta/issues/204
[vincentfretin]
3 changes: 3 additions & 0 deletions news/990.bugfix
@@ -0,0 +1,3 @@
Fix CSS issue on "Pattern options" tab in Resource Registries (padding-top of the tab content).
This fixes https://github.com/plone/Products.CMFPlone/issues/1111
[vincentfretin]
2 changes: 2 additions & 0 deletions news/991.bugfix
@@ -0,0 +1,2 @@
Fix some internationalization issues in structure pattern (folder_contents view): "Open", "Edit" and "Actions" tooltips are translated; all actions under "Actions" are translated; In filter menu the "No sorting" option of the sorting dropdown is translated.
[erral]
4 changes: 4 additions & 0 deletions news/996.bugfix
@@ -0,0 +1,4 @@
Fix regression for the disabled state of action buttons in folder contents
and the Tools/Build CSS button in thememapper.
This fixes https://github.com/plone/Products.CMFPlone/issues/2296
[vincentfretin]
2 changes: 2 additions & 0 deletions news/997.bugfix
@@ -0,0 +1,2 @@
Fix internationalization of "Filter" placeholder in selected items dialog.
[vincentfretin]

0 comments on commit 37b6880

Please sign in to comment.