Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport template plugin from TinyMCE 6 #1384

Merged
merged 3 commits into from
Jun 13, 2024
Merged

Conversation

petschki
Copy link
Member

No description provided.

@petschki petschki marked this pull request as draft June 12, 2024 07:33
@petschki petschki marked this pull request as ready for review June 12, 2024 07:46
Copy link
Sponsor Contributor

@1letter 1letter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i tested this here in my local sites and i see no errors. i can insert template like in version tinymce < 7.

Copy link
Member

@thet thet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does the TinyMCE license allow us to use the TinyMCE 6 plugin in TinyMCE 7?
If yes, I'm fine with merging this.

@petschki
Copy link
Member Author

petschki commented Jun 12, 2024

TinyMCE lincense is GPLv2+ ... since the "old" template plugin is distributed as "open source plugin" I assume it's ok to use the code ... we have to maintain it ourselfes anyway if it doesn't work anymore in a future tiny release. https://www.tiny.cloud/docs/tinymce/6/template/

@petschki petschki merged commit 4b8ac5c into master Jun 13, 2024
3 checks passed
@petschki petschki deleted the tinymce7-template-backport branch June 13, 2024 06:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants