Include Upload pattern progress bar styles for use by widgets #698
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
previously omitted.
seanupton
added a commit
to upiq/plone.app.widgets
that referenced
this pull request
Aug 18, 2016
…8, integrating fixes from plone/mockup#698 and plone/mockup#699
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upload pattern previously omitted any styles for progress bar, which breaks upload display of progress bar in plone.app.widgets 1.x (e.g. in TinyMCE upload tab).
This fixes that; it also fixes lack of the bootstrap scaffolding for the .sr-only selector.
LESS Imports are done by reference to keep resulting file size low. This style fix is very low risk: while it adds about 1.2k to the built widgets.min.css, once gzipped, the difference is only 64 additional bytes served over a compressed connection.