Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Momentjs: improve fallback for lazy load locales #890

Merged
merged 4 commits into from Feb 15, 2019

Conversation

davilima6
Copy link
Member

No description provided.

@mister-roboto
Copy link

@davilima6 thanks for creating this Pull Request and help improve Plone!

To ensure that these changes do not break other parts of Plone, the Plone test suite matrix needs to pass.

Whenever you feel that the pull request is ready to be tested, either start all jenkins jobs pull requests by yourself, or simply add a comment in this pull request stating:

@jenkins-plone-org please run jobs

With this simple comment all the jobs will be started automatically.

Happy hacking!

@davilima6
Copy link
Member Author

@jenkins-plone-org please run jobs

@coveralls
Copy link

coveralls commented Feb 13, 2019

Coverage Status

Coverage decreased (-0.007%) to 57.709% when pulling 39f2fa0 on momentjsLazyLoadLocales into a0a8b0c on master.

@jensens jensens merged commit 394625d into master Feb 15, 2019
@jensens jensens deleted the momentjsLazyLoadLocales branch February 15, 2019 14:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants