Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix alignment of the default page objects in the structure pattern #896

Merged
merged 1 commit into from Mar 6, 2019

Conversation

ale-rt
Copy link
Member

@ale-rt ale-rt commented Feb 23, 2019

Before:
image
After:
image

Closes #895

@mister-roboto
Copy link

@ale-rt thanks for creating this Pull Request and help improve Plone!

To ensure that these changes do not break other parts of Plone, the Plone test suite matrix needs to pass.

Whenever you feel that the pull request is ready to be tested, either start all jenkins jobs pull requests by yourself, or simply add a comment in this pull request stating:

@jenkins-plone-org please run jobs

With this simple comment all the jobs will be started automatically.

Happy hacking!

1 similar comment
@mister-roboto
Copy link

@ale-rt thanks for creating this Pull Request and help improve Plone!

To ensure that these changes do not break other parts of Plone, the Plone test suite matrix needs to pass.

Whenever you feel that the pull request is ready to be tested, either start all jenkins jobs pull requests by yourself, or simply add a comment in this pull request stating:

@jenkins-plone-org please run jobs

With this simple comment all the jobs will be started automatically.

Happy hacking!

@ale-rt
Copy link
Member Author

ale-rt commented Feb 23, 2019

@jenkins-plone-org please run jobs

@davilima6
Copy link
Member

@ale-rt, @pbauer, @agitator, @sneridagh, @polyester: any reason not to have it in bold as in Plone < 5? Also with same red square icon, to the right?

screenshot 2019-03-06 at 22 27 38

@ale-rt
Copy link
Member Author

ale-rt commented Mar 6, 2019

I like the bold idea and I am neutral about the square on the right vs the star on the left.
Not sure why it is like that, I just fixed the alignment with my poor css skills :)

@davilima6
Copy link
Member

No worries. I just ask because if there's agreement we can use this opportunity to change it to resume the Plone pre 5 tradition. Maybe it just lagged behind while feature pairing with previous folder_contents view

Copy link
Member

@davilima6 davilima6 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, we can improve next (or I can add a commit for bold, if you'd like)

@ale-rt ale-rt merged commit f2ee08b into master Mar 6, 2019
@ale-rt ale-rt deleted the 895-fix-alignment branch March 6, 2019 22:33
@fulv fulv restored the 895-fix-alignment branch June 5, 2019 18:39
@fulv
Copy link
Member

fulv commented Jun 5, 2019

I've applied the "proper" fix. Please re-merge.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix alignment of the default page element in the structure pattern
4 participants