New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix alignment of the default page objects in the structure pattern #896
Conversation
@ale-rt thanks for creating this Pull Request and help improve Plone! To ensure that these changes do not break other parts of Plone, the Plone test suite matrix needs to pass. Whenever you feel that the pull request is ready to be tested, either start all jenkins jobs pull requests by yourself, or simply add a comment in this pull request stating:
With this simple comment all the jobs will be started automatically. Happy hacking! |
1 similar comment
@ale-rt thanks for creating this Pull Request and help improve Plone! To ensure that these changes do not break other parts of Plone, the Plone test suite matrix needs to pass. Whenever you feel that the pull request is ready to be tested, either start all jenkins jobs pull requests by yourself, or simply add a comment in this pull request stating:
With this simple comment all the jobs will be started automatically. Happy hacking! |
@jenkins-plone-org please run jobs |
@ale-rt, @pbauer, @agitator, @sneridagh, @polyester: any reason not to have it in bold as in Plone < 5? Also with same red square icon, to the right? |
I like the bold idea and I am neutral about the square on the right vs the star on the left. |
No worries. I just ask because if there's agreement we can use this opportunity to change it to resume the Plone pre 5 tradition. Maybe it just lagged behind while feature pairing with previous |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm, we can improve next (or I can add a commit for bold, if you'd like)
I've applied the "proper" fix. Please re-merge. |
Before:
After:
Closes #895