Upgrade testing dependencies: Karma and Mocha

[davilima6]

Updated versions:

• Karma: from ~3.0.0 to ~4.1.0
• Mocha: from ~3.5.3 to ~6.1.4
• Chai: from ~3.5.0 to ~4.2.0

---

I postponed karma-sauce-launcher for now because it failed installing selenium-webdriver@4.0.0-alpha.4 with "incompatible linux platform" for fsversion@1.2.9:

• karma-sauce-launcher: from 1.2.0 to 2.0.2

yarn install v1.3.2
[1/5] Validating package.json...
[2/5] Resolving packages...
[3/5] Fetching packages...
info fsevents@1.2.9: The platform "linux" is incompatible with this module.
info "fsevents@1.2.9" is an optional dependency and failed compatibility check. Excluding it from installation.
error selenium-webdriver@4.0.0-alpha.4: The engine "node" is incompatible with this module. Expected version ">= 10.15.0".
error Found incompatible module

---

Finally we may include Sinon too if we solve the problem reported below.

• Sinon: from ~1.17.1 to ~7.3.6 (Upgrade sinon #914)

[mister-roboto]

@davilima6 thanks for creating this Pull Request and help improve Plone!

To ensure that these changes do not break other parts of Plone, the Plone test suite matrix needs to pass.

Whenever you feel that the pull request is ready to be tested, either start all jenkins jobs pull requests by yourself, or simply add a comment in this pull request stating:

@jenkins-plone-org please run jobs

With this simple comment all the jobs will be started automatically.

Happy hacking!

[davilima6]

@jenkins-plone-org please run jobs

[coveralls]

Coverage remained the same at 57.527% when pulling 6acb895 on upgrade_testing_deps into 7b32d1b on master.

[davilima6]

@thet, @vangheem: This PR is ready for merge but if you have an idea on the error below, we can include also here the upgrade of Sinon from 1.17.1 to 7.3.6: #914.

Sinon's Stub API changed slightly and I'm missing something (ae50e82) so 3 tests fail at same stub call:

  Structure traverse links
    ✗ test navigate to folder push states
	undefined is not an object (evaluating 'history.pushed.url')
	tests/pattern-structure-test.js:1306:28

    ✗ test navigate to folder push states - urlStructure
	undefined is not an object (evaluating 'history.pushed.url') A
	tests/pattern-structure-test.js:2153:28

    ✗ test navigate to folder push states - pushStateUrl
	undefined is not an object (evaluating 'history.pushed.url')
	tests/pattern-structure-test.js:2190:28

When I console.log(history) inside the test it I see the stub but if I do it at code level (patterns/structure/pattern.js) I see the original window.history. Any ideas?

[davilima6]

@jenkins-plone-org please run jobs

[thet]

LGTM.
Regarding the test failures with Sinon - I recently stumbled upon the same problem and gave up fixing the usage of the Sinon API in mockup. I'd merge it without an Sinon upgrade.

[davilima6]

Alright, let’s leave Sinon for #914.

For this one I don’t think any bundle needs to be recompiled in p.staticresources, but if there’s any please let me know. Thanks!

[davilima6]

Btw I believe no bundles need to be recompiled because only devDependencies were updated.