Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Get pastanaga and pastanaga-theme from github #49

Closed
wants to merge 3 commits into from
Closed

Get pastanaga and pastanaga-theme from github #49

wants to merge 3 commits into from

Conversation

jaroel
Copy link
Member

@jaroel jaroel commented Oct 20, 2017

Closes #47

@jaroel
Copy link
Member Author

jaroel commented Oct 20, 2017

This fails because of the git+ssh checkout. Needs https checkout?

@jaroel
Copy link
Member Author

jaroel commented Oct 21, 2017

This will work once pastanaga-theme is published (it's private now).

@coveralls
Copy link

Coverage Status

Coverage remained the same at 58.145% when pulling 64450a3 on 47-pastanaga-theme-checkout into b2658ad on master.

@robgietema
Copy link
Member

I'll close this one for now till we have a clean pastanaga package, for now the theme will be in plone-react itself.

@robgietema robgietema closed this Feb 13, 2018
@robgietema robgietema deleted the 47-pastanaga-theme-checkout branch February 13, 2018 16:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@jaroel @coveralls @robgietema