Skip to content

Commit

Permalink
Merge pull request #44 from plone/fix_header
Browse files Browse the repository at this point in the history
Adapt test to added charset in Zope4 (ZPublisher.HTTPResponse.setHeader)
  • Loading branch information
pbauer committed Oct 28, 2017
2 parents 1931481 + 600e006 commit ad6de84
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 4 deletions.
3 changes: 2 additions & 1 deletion CHANGES.rst
Expand Up @@ -14,7 +14,8 @@ New features:

Bug fixes:

- *add item here*
- Adapt test to changes in ZPublisher.HTTPResponse.setHeader
[pbauer]


1.7.2 (2017-06-03)
Expand Down
7 changes: 4 additions & 3 deletions src/plone/app/blob/tests/test_replacements.py
Expand Up @@ -57,11 +57,12 @@ def testCreateFileBlob(self):
self.assertEqual(foo.get_size(), 10)
request = foo.REQUEST
response = request.RESPONSE
self.assertEqual(foo.index_html(
request, response).next(), 'plain text')
index = foo.index_html(request, response)
self.assertEqual(index.next(), 'plain text')
self.assertEqual(response.getStatus(), 200)
self.assertEqual(response.headers['content-length'], '10')
self.assertEqual(response.headers['content-type'], 'text/plain')
self.assertTrue(
response.headers['content-type'].startswith('text/plain'))

def testFileBlobInterfaces(self):
foo = self.folder[self.folder.invokeFactory('File', 'foo')]
Expand Down

1 comment on commit ad6de84

@jenkins-plone-org
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@pbauer Jenkins CI reporting about code analysis
See the full report here: http://jenkins.plone.org/job/package-plone.app.blob/42/violations

src/plone/app/blob/iterators.py:13:9: D001 found implements( replace it with zope.interface.implementer
src/plone/app/blob/scale.py:27:5: D001 found adapts( replace it with zope.component.adapter
src/plone/app/blob/scale.py:51:42: C812 missing trailing comma
src/plone/app/blob/scale.py:74:5: D001 found adapts( replace it with zope.component.adapter
src/plone/app/blob/content.py:135:13: T000 Todo note found.
src/plone/app/blob/content.py:153:18: C812 missing trailing comma
src/plone/app/blob/content.py:254:1: E305 expected 2 blank lines after class or function definition, found 1
src/plone/app/blob/interfaces.py:10:37: Q000 Remove bad quotes.
src/plone/app/blob/interfaces.py:13:17: Q000 Remove bad quotes.
src/plone/app/blob/interfaces.py:14:23: Q000 Remove bad quotes.
src/plone/app/blob/interfaces.py:15:22: C812 missing trailing comma
src/plone/app/blob/markings.py:3:3: T000 Todo note found.
src/plone/app/blob/markings.py:9:1: I001 isort found an import in the wrong position
src/plone/app/blob/monkey.py:2:3: T000 Todo note found.
src/plone/app/blob/monkey.py:47:1: E305 expected 2 blank lines after class or function definition, found 1
src/plone/app/blob/monkey.py:53:12: P002 found "hasattr", consider replacing it
src/plone/app/blob/monkey.py:56:1: E305 expected 2 blank lines after class or function definition, found 1
src/plone/app/blob/migrations.py:43:1: C901 'makeMigrator' is too complex (15)
src/plone/app/blob/migrations.py:55:80: E501 line too long (115 > 79 characters)
src/plone/app/blob/migrations.py:83:20: P002 found "hasattr", consider replacing it
src/plone/app/blob/field.py:45:12: P002 found "hasattr", consider replacing it
src/plone/app/blob/field.py:97:24: C812 missing trailing comma
src/plone/app/blob/field.py:99:25: C812 missing trailing comma
src/plone/app/blob/field.py:143:11: T000 Todo note found.
src/plone/app/blob/field.py:198:1: E305 expected 2 blank lines after class or function definition, found 1
src/plone/app/blob/field.py:278:16: P002 found "hasattr", consider replacing it
src/plone/app/blob/field.py:282:46: C812 missing trailing comma
src/plone/app/blob/field.py:288:24: C812 missing trailing comma
src/plone/app/blob/field.py:290:25: C812 missing trailing comma
src/plone/app/blob/field.py:303:37: C812 missing trailing comma
src/plone/app/blob/field.py:309:50: T000 Todo note found.
src/plone/app/blob/field.py:313:38: C815 missing trailing comma in Python 3.5+
src/plone/app/blob/field.py:343:1: E305 expected 2 blank lines after class or function definition, found 1
src/plone/app/blob/field.py:346:50: C812 missing trailing comma
src/plone/app/blob/field.py:360:1: E305 expected 2 blank lines after class or function definition, found 1
src/plone/app/blob/field.py:363:50: C812 missing trailing comma
src/plone/app/blob/field.py:387:12: P002 found "hasattr", consider replacing it
src/plone/app/blob/field.py:390:1: E305 expected 2 blank lines after class or function definition, found 1
src/plone/app/blob/field.py:393:50: C812 missing trailing comma
src/plone/app/blob/download.py:35:1: C901 'handleRequestRange' is too complex (14)
src/plone/app/blob/browser/size.py:30:19: S001 found module formatter
src/plone/app/blob/browser/size.py:42:16: S001 found module formatter
src/plone/app/blob/browser/size.py:46:9: E731 do not assign a lambda expression, use a def
src/plone/app/blob/browser/migration.py:34:26: C812 missing trailing comma
src/plone/app/blob/browser/migration.py:42:26: C812 missing trailing comma
src/plone/app/blob/browser/maintenance.py:29:12: S001 found module formatter
src/plone/app/blob/adapters/pdata.py:13:5: D001 found adapts( replace it with zope.component.adapter
src/plone/app/blob/adapters/blobwrapper.py:12:5: D001 found adapts( replace it with zope.component.adapter
src/plone/app/blob/adapters/atimage.py:9:5: D001 found adapts( replace it with zope.component.adapter
src/plone/app/blob/adapters/atimage.py:17:43: T000 Todo note found.
src/plone/app/blob/adapters/webdav.py:12:5: D001 found adapts( replace it with zope.component.adapter
src/plone/app/blob/adapters/file.py:11:5: D001 found adapts( replace it with zope.component.adapter
src/plone/app/blob/adapters/xmlrpc.py:12:5: D001 found adapts( replace it with zope.component.adapter
src/plone/app/blob/adapters/atfile.py:12:5: D001 found adapts( replace it with zope.component.adapter
src/plone/app/blob/adapters/stringio.py:12:5: D001 found adapts( replace it with zope.component.adapter
src/plone/app/blob/adapters/fileupload.py:17:5: D001 found adapts( replace it with zope.component.adapter
src/plone/app/blob/adapters/ofsfile.py:11:5: D001 found adapts( replace it with zope.component.adapter
src/plone/app/blob/adapters/ofsfile.py:19:51: T000 Todo note found.
src/plone/app/blob/tests/test_maintenance.py:6:1: I003 isort expected 1 blank line in imports, found 0
src/plone/app/blob/tests/test_integration.py:164:41: P101 format string does contain unindexed parameters
src/plone/app/blob/tests/test_integration.py:167:41: P101 format string does contain unindexed parameters
src/plone/app/blob/tests/test_integration.py:238:44: C812 missing trailing comma
src/plone/app/blob/tests/test_replacements.py:19:1: I001 isort found an import in the wrong position
src/plone/app/blob/tests/test_replacements.py:72:31: C812 missing trailing comma
src/plone/app/blob/tests/test_replacements.py:78:36: C812 missing trailing comma
src/plone/app/blob/tests/test_replacements.py:82:34: C812 missing trailing comma
src/plone/app/blob/tests/test_replacements.py:93:38: C812 missing trailing comma
src/plone/app/blob/tests/test_replacements.py:109:73: C812 missing trailing comma
src/plone/app/blob/tests/test_replacements.py:131:38: C812 missing trailing comma
src/plone/app/blob/tests/test_replacements.py:145:73: C812 missing trailing comma
src/plone/app/blob/tests/test_replacements.py:160:45: C812 missing trailing comma
src/plone/app/blob/tests/test_replacements.py:168:44: C812 missing trailing comma
src/plone/app/blob/tests/test_replacements.py:180:42: C812 missing trailing comma
src/plone/app/blob/tests/test_replacements.py:196:42: C812 missing trailing comma
src/plone/app/blob/tests/test_replacements.py:210:42: C812 missing trailing comma
src/plone/app/blob/tests/test_replacements.py:225:42: C812 missing trailing comma
src/plone/app/blob/tests/test_replacements.py:290:38: C812 missing trailing comma
src/plone/app/blob/tests/test_replacements.py:373:22: C812 missing trailing comma
src/plone/app/blob/tests/test_replacements.py:381:44: C812 missing trailing comma
src/plone/app/blob/tests/test_replacements.py:414:9: E731 do not assign a lambda expression, use a def
src/plone/app/blob/tests/base.py:29:1: E305 expected 2 blank lines after class or function definition, found 1
src/plone/app/blob/tests/base.py:37:1: E305 expected 2 blank lines after class or function definition, found 1
src/plone/app/blob/tests/test_base_fields.py:40:1: E305 expected 2 blank lines after class or function definition, found 1
src/plone/app/blob/tests/test_base_fields.py:101:43: C812 missing trailing comma
src/plone/app/blob/tests/utils.py:59:9: T001 print statement found.
src/plone/app/blob/tests/utils.py:60:9: T001 print statement found.
src/plone/app/blob/tests/utils.py:61:9: T001 print statement found.
src/plone/app/blob/tests/lingua.py:35:1: E305 expected 2 blank lines after class or function definition, found 1
src/plone/app/blob/tests/test_doctests.py:33:35: C812 missing trailing comma
src/plone/app/blob/tests/layer.py:30:1: E305 expected 2 blank lines after class or function definition, found 1
src/plone/app/blob/tests/layer.py:51:62: C812 missing trailing comma
src/plone/app/blob/tests/layer.py:74:1: E305 expected 2 blank lines after class or function definition, found 1
src/plone/app/blob/tests/layer.py:109:1: E305 expected 2 blank lines after class or function definition, found 1
src/plone/app/blob/subtypes/image.py:25:12: P002 found "hasattr", consider replacing it
src/plone/app/blob/subtypes/image.py:51:50: C812 missing trailing comma
src/plone/app/blob/subtypes/image.py:57:14: C812 missing trailing comma
src/plone/app/blob/subtypes/blob.py:33:49: C812 missing trailing comma
src/plone/app/blob/subtypes/blob.py:39:14: C812 missing trailing comma
src/plone/app/blob/subtypes/file.py:37:49: C812 missing trailing comma
src/plone/app/blob/subtypes/file.py:43:14: C812 missing trailing comma

Follow these instructions to reproduce it locally.

Please sign in to comment.