Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enforce plone.subrequest >= 1.7.0 #70

Merged
merged 2 commits into from
Jul 9, 2018
Merged

Enforce plone.subrequest >= 1.7.0 #70

merged 2 commits into from
Jul 9, 2018

Conversation

hvelarde
Copy link
Member

@hvelarde hvelarde commented Jul 5, 2018

This avoids TypeError on package upgrades.

closes #62

@hvelarde
Enforce plone.subrequest >= 1.7.0
217ac93 
This avoids TypeError on package upgrades.
@hvelarde hvelarde self-assigned this Jul 5, 2018
@coveralls
Copy link

coveralls commented Jul 5, 2018 •
edited
Loading

Coverage Status

Coverage remained the same at 77.871% when pulling 217ac93 on hvelarde-subrequest into 977666f on master.

datakurre
datakurre approved these changes Jul 8, 2018
View reviewed changes
Copy link
Member

@datakurre datakurre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changelog entry is required to turn the pull green.

jensens
jensens approved these changes Jul 9, 2018
View reviewed changes
Copy link
Sponsor Member

@jensens jensens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am fine with this, please add a short note in the changelog.

@hvelarde
Update changelog
8ef6981 
[skip ci]
@hvelarde hvelarde merged commit 9f5c18c into master Jul 9, 2018
@hvelarde hvelarde deleted the hvelarde-subrequest branch July 9, 2018 21:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jensens jensens jensens approved these changes

@datakurre datakurre datakurre approved these changes

Assignees

@hvelarde hvelarde

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

TypeError after upgrading from 2.2.1 to 4.1.0
4 participants
@hvelarde @coveralls @jensens @datakurre