Make contentlisting work with plone.app.contenttypes collections #25
Conversation
|
This is to make folder_contents works both on plone.app.contenttypes & folders on plone4 |
|
nice! for plone.app.contenttypes, I'm working on something similar : plone/plone.app.contenttypes#202 |
|
yep but that's for plone5, my little commit makes the listing beginning to work with the branch for plone4 :) |
|
i think your approach in the long term is better, it is just way too invasive rather than mine in the idea that i dont had the time to do the nice refactor you are going on, so i did that proxy trick to make things assemble on plone4.3 |
|
oh, sorry, i have mistaken folder_contents as folder_listing. but they are completly different views. but what is the usecase behind looking at folder_contents for collections? are you going to show the collection results in the folder_contents view for collections? recently i was wondering, if we could get rid of plone.app.content in Plone 5 at all and merge all of plone.app.content's stuff into CMFPlone... but that's another topic and does not affect Plone 4. |
| datetime.datetime, | ||
| datetime.time, | ||
| float, list, set, tuple)): | ||
| ret = ret() |
There was a problem hiding this comment.
is this clause the same like doing it like so?
from Products.CMFPlone.utils import safe_callable
if safe_callable(ret):
ret = ret()
There was a problem hiding this comment.
maybe yes, i should read the code of safe_callable :)
|
merge @ebrehault ? you have more insight... |
|
For the use case, we use folder_contents to post to a custom view via portal_actions (the user select boxes on folder_contents) and that is posted to a custom view via a custom action in folder_buttons. The view is here; https://github.com/RBINS/rbins_masschange/blob/master/src/rbins_masschange/browser/masschange.py I know that there is a view on plone5 which may have all if not better features of this view, but this view is older and works on plone4 :p |
|
what i still don't understand is: is your collection type folderish? in |
|
@thet you didnt see plone/plone.app.layout/pull/40 didnt you |
|
@jensens @pbauer @ebrehault do someone of you have some time to look at this? i'm currently too busy to handle this. |
|
see discussion at: plone/plone.app.layout#40 |
|
I close this one, if you think this is wrong please reopen and comment. |
cc @ebrehault @vangheem