Plip1734thumbs

[fgrcon]

provide Mimetype icon path for file types in contentlisting object
plone/Products.CMFPlone#173

[fgrcon]

What the hell is going on ? I checked http://docs.plone.org/develop/styleguide/python.html ran isort accordingly .... but ????

[gforcada]

@fgrcon did you have an .isort.cfg file? If not isort sorts the files in a totally different style, see http://jenkinsploneorg.readthedocs.io/en/latest/run-qa-on-package.html for what mr.roboto is actually doing

[fgrcon]

@gforcada: Thanks for the hint, but I had done correctly afaik . But following the instructions ... and:

root@debian:/usr/local/p5dev/2buildout/src/plone.app.contentlisting# isort -rc -c -vb -sp /usr/local/p5dev/2buildout/src/plone.app.contentlisting/.isort.cfg plone/
SUCCESS: /usr/local/p5dev/2buildout/src/plone.app.contentlisting/plone/init.py Everything Looks Good!
SUCCESS: /usr/local/p5dev/2buildout/src/plone.app.contentlisting/plone/app/init.py Everything Looks Good!
SUCCESS: /usr/local/p5dev/2buildout/src/plone.app.contentlisting/plone/app/contentlisting/init.py Everything Looks Good!
SUCCESS: /usr/local/p5dev/2buildout/src/plone.app.contentlisting/plone/app/contentlisting/interfaces.py Everything Looks Good!
SUCCESS: /usr/local/p5dev/2buildout/src/plone.app.contentlisting/plone/app/contentlisting/catalog.py Everything Looks Good!
SUCCESS: /usr/local/p5dev/2buildout/src/plone.app.contentlisting/plone/app/contentlisting/contentlisting.py Everything Looks Good!
SUCCESS: /usr/local/p5dev/2buildout/src/plone.app.contentlisting/plone/app/contentlisting/realobject.py Everything Looks Good!
SUCCESS: /usr/local/p5dev/2buildout/src/plone.app.contentlisting/plone/app/contentlisting/browser.py Everything Looks Good!
SUCCESS: /usr/local/p5dev/2buildout/src/plone.app.contentlisting/plone/app/contentlisting/tests/init.py Everything Looks Good!
SUCCESS: /usr/local/p5dev/2buildout/src/plone.app.contentlisting/plone/app/contentlisting/tests/test_integration_unit.py Everything Looks Good!
SUCCESS: /usr/local/p5dev/2buildout/src/plone.app.contentlisting/plone/app/contentlisting/tests/test_integration_doctest.py Everything Looks Good!
SUCCESS: /usr/local/p5dev/2buildout/src/plone.app.contentlisting/plone/app/contentlisting/tests/base.py Everything Looks Good!
root@debian:/usr/local/p5dev/2buildout/src/plone.app.contentlisting#

.isort.cfg in the project path as well as ~/.isort.cfg match the documented config exactly.

[gforcada]

@fgrcon so if you run isort and changes the files, what are the changes being made? a git diff will be enough to check that

[fgrcon]

the diff is here: ee5e70b
Isort worked correctly ? So whats wrong now ?

[gforcada]

No, it didn't work correctly, the proper sorting is:

from X import Y
from X import Y  # no blank lines in between
from X import Y

import X
import Y