Skip to content

Commit

Permalink
Update changelog with TALES expression cause.
Browse files Browse the repository at this point in the history
  • Loading branch information
davidjb committed Sep 10, 2013
1 parent 76978f0 commit 98ae3ba
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 2 deletions.
3 changes: 2 additions & 1 deletion CHANGES.rst
Expand Up @@ -5,7 +5,8 @@ Changelog
------------------

- Workaround ``KeyError: context`` for unicode TALES expressions in content
rules by providing the expression ``context``.
rules by providing the expression ``context``. This was triggered by a
TALES expression such as ``u'string:${portal_url}``.
[davidjb]


Expand Down
Expand Up @@ -68,7 +68,7 @@ def testExecute(self):
ex = getMultiAdapter((self.portal, e, DummyEvent(self.folder)), IExecutable)
self.assertEquals(True, ex())

def testExecuteUnicode(self):
def testExecuteUnicodeString(self):
e = TalesExpressionCondition()
e.tales_expression = u'string:${portal_url}'
ex = getMultiAdapter((self.portal, e, DummyEvent(self.folder)), IExecutable)
Expand Down

3 comments on commit 98ae3ba

@mister-roboto
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Testing information:

@tdesvenain
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thank you

@davidjb
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This represents a bigger issue with using Unicode TALES string: expressions in Plone. See https://dev.plone.org/ticket/13728 for more info.

Please sign in to comment.