Skip to content

Commit

Permalink
delete at member-folder before creating new default-content
Browse files Browse the repository at this point in the history
  • Loading branch information
@pbauer
pbauer committed Feb 19, 2014
1 parent 5e0ca87 commit c74c397
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion plone/app/contenttypes/setuphandlers.py
View file
Expand Up @@ -387,7 +387,7 @@ def _delete_at_example_content(portal):
]
if not [i.id for i in all_content] == expected:
return
to_delete = ['front-page', 'news', 'events']
to_delete = ['front-page', 'news', 'events', 'Members']
for i in to_delete:
obj = portal[i]
if IDexterityContent.providedBy(obj):
Expand Down

7 comments on commit c74c397

@mister-roboto
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TESTS PASSED
Mr.Roboto url : http://jenkins.plone.org/roboto/get_info?push=1dd0c79c4c8a4b78be71fde1c59baed0
[SUCCESS] kgs-plone.app.contenttypes-plone-5.0-python-2.7 kgs

@tisto
Copy link
Member

@tisto tisto commented on c74c397 Feb 21, 2014

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@pbauer: One of your commits broke the Plone 5.0 build. http://jenkins.plone.org/job/plone-5.0-python-2.7/1665/console

Please revert this commit or fix the test. It seems other tests expect the Member folder to be present.

@davisagli
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually no, this failure is my fault (from the change to the Members folder default view) and I am fixing it

@tisto
Copy link
Member

@tisto tisto commented on c74c397 Feb 21, 2014

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bloodbare Is it possible to disable the KGS github notifications? Those are highly confusing for people. For instance this commit broke the build. Though, the KGS notification says [SUCCESS].

@davisagli
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tisto, no it was this change that broke the build: plone/Products.CMFPlone@a6f26b9 (because p.a.controlpanel still uses a fixture with ATContentTypes, and ATContentTypes was still setting up the Members folder with a reference to the form I removed)

@tisto
Copy link
Member

@tisto tisto commented on c74c397 Feb 21, 2014

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@pbauer: Sorry for the wrong accusation. :)

One Jenkins job was stuck and it was hard to figure out which commit actually broke the build.

@pbauer
Copy link
Member Author

@pbauer pbauer commented on c74c397 Feb 21, 2014

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tisto no problem.

Please sign in to comment.