Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Translate everything #37

Closed
pbauer opened this issue Apr 7, 2013 · 2 comments
Closed

Translate everything #37

pbauer opened this issue Apr 7, 2013 · 2 comments
Labels
02 type: regression

Comments

@pbauer
Copy link
Sponsor Member

pbauer commented Apr 7, 2013

Most of the strings used in the schemata already exist in the i18n-domain 'atcontenttypes'. The corresponding po-file holds 176 different values. Should we use this domain, create a new domain and copy the neccessary translations or use 'plone' like the skin-templates in CMFPlone do?
@pbauer pbauer mentioned this issue Apr 7, 2013
Closed
@jensens
Copy link
Sponsor Member

jensens commented Oct 13, 2017

is this still an issue?

@mauritsvanrees
Copy link
Sponsor Member

behaviors/tableofcontents.py uses the atcontentypes domain. But the two strings here are already in plone.app.locales under the plone domain, so that is no problem to switch.
All other instances of MessageFactory and i18n:domain and i18n_domain are for the plone domain, so that is good.
Let me open a PR.

mauritsvanrees added a commit that referenced this issue Oct 17, 2017
@mauritsvanrees
Remove last use of atcontenttypes translation domain.
b7b4025 
Fixes #37.
@mauritsvanrees mauritsvanrees mentioned this issue Oct 17, 2017
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
02 type: regression
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@jensens @mauritsvanrees @pbauer