Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Revert "reflect moves from plone.app.widgets to plone.app.z3cform"" #288

Merged
merged 2 commits into from
Apr 11, 2019

Conversation

jensens
Copy link
Sponsor Member

@jensens jensens commented Apr 9, 2019

Reverts #287

2nd trial...

@mister-roboto
Copy link

@jensens thanks for creating this Pull Request and help improve Plone!

To ensure that these changes do not break other parts of Plone, the Plone test suite matrix needs to pass.

Whenever you feel that the pull request is ready to be tested, either start all jenkins jobs pull requests by yourself, or simply add a comment in this pull request stating:

@jenkins-plone-org please run jobs

With this simple comment all the jobs will be started automatically.

Happy hacking!

@jensens
Copy link
Sponsor Member Author

jensens commented Apr 9, 2019

@jenkins-plone-org please run jobs

@pbauer
Copy link
Sponsor Member

pbauer commented Apr 11, 2019

@jensens Is this ready for merging together with plone/plone.app.vocabularies#56, plone/plone.app.z3cform#104 and plone/plone.app.widgets#194?

@jensens
Copy link
Sponsor Member Author

jensens commented Apr 11, 2019

@pbauer for Plone 5.2, yes. Since p.a.dexterity is on master for Plone 5.1 this needs to be tested.

@jensens
Copy link
Sponsor Member Author

jensens commented Apr 11, 2019

@pbauer last commit should do it, I start the tests now.

@pbauer pbauer merged commit badd683 into master Apr 11, 2019
@jensens jensens deleted the revert-287-revert-286-jensens/fixPloneFormLayer branch April 11, 2019 12:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants