Skip to content

Commit

Permalink
very basic form validation added to comments viewlet.
Browse files Browse the repository at this point in the history
svn path=/plone.app.discussion/trunk/; revision=27564
  • Loading branch information
Timo Stollenwerk committed Jun 21, 2009
1 parent 7eae478 commit b7b0b18
Showing 1 changed file with 56 additions and 0 deletions.
56 changes: 56 additions & 0 deletions plone/app/discussion/browser/comments.py
Expand Up @@ -18,6 +18,10 @@

from Products.CMFCore.utils import getToolByName

from Products.CMFPlone import PloneMessageFactory as _

from Products.statusmessages.interfaces import IStatusMessage

from plone.registry.interfaces import IRegistry

from plone.app.layout.viewlets.common import ViewletBase
Expand Down Expand Up @@ -142,6 +146,32 @@ def __call__(self):
author_username = self.request.get('author_username')
author_email = self.request.get('author_email')

# Check the form input
if author_username == '':
IStatusMessage(self.request).addStatusMessage(\
_("Username field is empty."),
type="info")
self.request.response.redirect(aq_parent(aq_inner(self.context)).absolute_url())
return None
if author_email == '':
IStatusMessage(self.request).addStatusMessage(\
_("Email field is empty."),
type="info")
self.request.response.redirect(aq_parent(aq_inner(self.context)).absolute_url())
return None
if subject == '':
IStatusMessage(self.request).addStatusMessage(\
_("Subject field is empty."),
type="info")
self.request.response.redirect(aq_parent(aq_inner(self.context)).absolute_url())
return None
if text == '':
IStatusMessage(self.request).addStatusMessage(\
_("Comment field is empty."),
type="info")
self.request.response.redirect(aq_parent(aq_inner(self.context)).absolute_url())
return None

# The add-comment view is called on the conversation object
conversation = self.context

Expand Down Expand Up @@ -190,6 +220,32 @@ def __call__(self):
author_username = self.request.get('author_username')
author_email = self.request.get('author_email')

# Check the form input
if author_username == '':
IStatusMessage(self.request).addStatusMessage(\
_("Username field is empty."),
type="info")
self.request.response.redirect(aq_parent(aq_inner(self.context)).absolute_url())
return None
if author_email == '':
IStatusMessage(self.request).addStatusMessage(\
_("Email field is empty."),
type="info")
self.request.response.redirect(aq_parent(aq_inner(self.context)).absolute_url())
return None
if subject == '':
IStatusMessage(self.request).addStatusMessage(\
_("Subject field is empty."),
type="info")
self.request.response.redirect(aq_parent(aq_inner(self.context)).absolute_url())
return None
if text == '':
IStatusMessage(self.request).addStatusMessage(\
_("Comment field is empty."),
type="info")
self.request.response.redirect(aq_parent(aq_inner(self.context)).absolute_url())
return None

# The add-comment view is called on the conversation object
conversation = self.context

Expand Down

0 comments on commit b7b0b18

Please sign in to comment.