Skip to content

Commit

Permalink
Merge pull request #4 from plone/gforcada-testing
Browse files Browse the repository at this point in the history
Update testing
  • Loading branch information
gforcada committed Aug 22, 2016
2 parents 36e8630 + a805be2 commit f924ecd
Show file tree
Hide file tree
Showing 6 changed files with 76 additions and 21 deletions.
9 changes: 9 additions & 0 deletions .coveragerc
@@ -0,0 +1,9 @@
[report]
omit =
/home/*/.buildout/eggs/*
/usr/*
bin/test
/home/travis/buildout-cache/eggs/*
/home/travis/virtualenv/*
eggs/*
parts/*
36 changes: 26 additions & 10 deletions .travis.yml
@@ -1,16 +1,32 @@
language: python
python: '2.7'
python: 2.7
sudo: false
env:
- PLONE_VERSION=4.x
- PLONE_VERSION=5.x
cache:
pip: true
directories:
- eggs
- $HOME/buildout-cache
matrix:
fast_finish: true
before_install:
- mkdir -p $HOME/buildout-cache/{eggs,downloads}
- mkdir $HOME/.buildout
- echo "[buildout]" > $HOME/.buildout/default.cfg
- echo "download-cache = $HOME/buildout-cache/downloads" >> $HOME/.buildout/default.cfg
- echo "eggs-directory = $HOME/buildout-cache/eggs" >> $HOME/.buildout/default.cfg
- pip install zc.buildout
- cp test-$PLONE_VERSION.cfg buildout.cfg
install:
- python bootstrap.py -v 1.7.1 -c test-$PLONE_VERSION.cfg
- bin/buildout -N -t 3 -c test-$PLONE_VERSION.cfg annotate
- bin/buildout -N -t 3 -c test-$PLONE_VERSION.cfg
- buildout -N -t 3 annotate
- buildout -N -t 3
script:
- bin/test
env:
matrix:
- PLONE_VERSION=4.x
- PLONE_VERSION=5.x
- bin/code-analysis
- bin/test
after_success:
- bin/createcoverage
- pip install -q coveralls
- coveralls
notifications:
irc: irc.freenode.org#plone-testing
3 changes: 3 additions & 0 deletions CHANGES.rst
Expand Up @@ -9,6 +9,9 @@ Changelog
- Fix code analysis errors.
[gforcada]

- Update testing infrastructure.
[gforcada]

1.0 (2016-03-28)
----------------

Expand Down
12 changes: 8 additions & 4 deletions README.rst
@@ -1,6 +1,14 @@
Introduction
============

.. image:: https://secure.travis-ci.org/plone/plone.app.drafts.png?branch=master
:alt: Travis CI badge
:target: http://travis-ci.org/plone/plone.app.drafts

.. image:: https://coveralls.io/repos/plone/plone.app.drafts/badge.png?branch=master
:alt: Coveralls badge
:target: https://coveralls.io/r/plone/plone.app.drafts

plone.app.drafts implements services for managing auto-saved content drafts in Plone.
This addresses two problems:

Expand All @@ -13,10 +21,6 @@ This addresses two problems:
The former problem pertains to any content add or edit form.
The latter applies in particular to the "tiles" model as implemented by `plone.app.tiles`_ and its dependencies.

.. image:: https://secure.travis-ci.org/plone/plone.app.drafts.png
:target: http://travis-ci.org/plone/plone.app.drafts


Installation
============

Expand Down
19 changes: 16 additions & 3 deletions test-4.x.cfg
@@ -1,8 +1,21 @@
[buildout]
extends =
https://raw.github.com/collective/buildout.plonetest/master/test-4.x.cfg
https://raw.githubusercontent.com/plone/plone.app.robotframework/master/versions.cfg
https://raw.githubusercontent.com/collective/buildout.plonetest/master/test-4.x.cfg
https://raw.githubusercontent.com/collective/buildout.plonetest/master/qa.cfg

package-name = plone.app.drafts
package-extras = [test]
versions = versions

show-picked-versions = true

parts +=
createcoverage

[code-analysis]
directory = plone
flake8-ignore = E501,C901

[versions]
setuptools =
coverage = >=3.7
plone.tiles =
18 changes: 14 additions & 4 deletions test-5.x.cfg
@@ -1,11 +1,21 @@
[buildout]
extends =
https://raw.github.com/collective/buildout.plonetest/master/test-5.x.cfg
https://raw.githubusercontent.com/plone/plone.app.robotframework/master/versions.cfg
https://raw.githubusercontent.com/collective/buildout.plonetest/master/test-5.x.cfg
https://raw.githubusercontent.com/collective/buildout.plonetest/master/qa.cfg

package-name = plone.app.drafts
package-extras = [test]
versions = versions

show-picked-versions = true

parts +=
createcoverage

[code-analysis]
directory = plone
flake8-ignore = E501,C901

[versions]
zc.buildout = 1.7.1
setuptools =
coverage = >=3.7
plone.tiles =

1 comment on commit f924ecd

@jenkins-plone-org
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@gforcada Jenkins CI reporting about code analysis
See the full report here: http://jenkins.plone.org/job/package-plone.app.drafts/12/violations

plone/app/drafts/dexterity.py:135:1: C901 'autosave' is too complex (15)
plone/app/drafts/tests.py:1141:15: S001 found % formatter
plone/app/drafts/tests.py:1181:15: S001 found % formatter
plone/app/drafts/tests.py:1228:15: S001 found % formatter

Follow these instructions to reproduce it locally.

Please sign in to comment.