Enabling IEventBasic for existing objects fails in 1.1.1

[pbauer]

When enabling IEventBasic for existing objects in p.a.e. 1.1.1 the objects have no start&end. Thus inline-validation fails and they can't be editied.

Traceback (innermost last):
 Module ZPublisher.Publish, line 138, in publish
 Module ZPublisher.mapply, line 77, in mapply
 Module Products.PDBDebugMode.runcall, line 70, in pdb_runcall
 Module ZPublisher.Publish, line 48, in call_object
 Module plone.app.z3cform.inline_validation, line 29, in __call__
 Module z3c.form.group, line 97, in extractData
 Module z3c.form.group, line 64, in extractData
 Module z3c.form.form, line 146, in extractData
 Module z3c.form.field, line 324, in extract
 Module z3c.form.field, line 216, in validate
 Module z3c.form.validator, line 201, in validate
 Module z3c.form.validator, line 206, in validateObject
 Module zope.interface.interface, line 590, in validateInvariants
 Module plone.app.event.dx.behaviors, line 140, in validate_start_end
 Module z3c.form.validator, line 175, in __getattr__
 Module z3c.form.datamanager, line 71, in get
 Module plone.app.event.dx.behaviors, line 358, in start
AttributeError: start

[Gomez]

This bug is described in the mastering plone trainig:

https://github.com/plone/training/blob/master/events.rst

Update if fixed or more info available.

[thet]

should be fixed now! @Gomez @pbauer can you please verify?
if it works for you, i can make a release and the bug-reference in http://plone-training.readthedocs.org/en/latest/events.html should be removed

[Gomez]

I will go through it soon, will update then

[thet]

the commit f5c316b was replaced by a1c1d69

[Gomez]

Steps to reproduce:

1. Buildout: https://github.com/collective/training_buildout
   Now you need to make a small change to the buildout. Open the file buildout.cfg in an editor and add a # at the beginning of line 25 where it says buildout_dir = /home/vagrant. Then remove the # at the next line. Activate ploneconf.site
2. cd src;git clone https://github.com/collective/ploneconf.site_sneak.git
3. cp -Rf src/ploneconf.site_sneak/chapters/23_dexterity_2/ src/ploneconf.site
4. Install ploneconf.site
5. Create a talk ct
6. Active Event Basic behavior
7. Try to open the previous talk ct

[thet]

i began to work on it here:
65fa06b

the problem is that no templates or code should rely on the necessary attributes beeing actually set. which is cumbersome - there are many more places which need this fix (e.g. ical export, probably event_listing too). at least the possible areas where we have to apply this fix can be found via a test (by extending AbstractSampleDataEvents in https://github.com/plone/plone.app.event/blob/1.1.x/plone/app/event/tests/base_setup.py#L32)

i have to consult my pillow about that. maybe it's the best to provide an upgrade script which fixes all contents with some default values. but which default values should then be used?

however, i can't spend much more time for it this week, i fear...

[pbauer]

Closed due to long inactivity. Please reopen if this is still relevant for Plone 5.2 or 6.