plone.autoform.directives and more generic javascript #228
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| else: | ||
| # Plone 4 | ||
| from plone.app.widgets.dx import DatetimeWidget | ||
| from plone.app.widgets.dx import DatetimeFieldWidget |
There was a problem hiding this comment.
if you skip Plone 4 support this can be removed as well?
There was a problem hiding this comment.
True - But removing Plone 4 support is more than that. I'd like to make a separate PR for that.
|
I'm wondering if there is a programmatic way to be used in an upgrade step to "re-cook" javascript... |
|
|
|
@vincentfretin although it's from the plone-legacy bundle, but in Plone 5 it's different, no? |
|
Ah, I don't know about Plone 5. |
…ead of overriding the default Fieldwidget adapters.
This makes it easier to use same selectors also for derived behaviors.
…works also for derived classes.
…0.1.dev0, which is only available for Plone >= 5.1
|
what’s the state here? do we need some "cooking" or is this sufficient? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes it easier to use same selectors also for derived behaviors.
plone.autoform.directivesfor manipulating field widgets instead of overriding the default Fieldwidget adapters.