Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix test_long_event when run around midnight of first day of month #383

Merged
merged 2 commits into from
Oct 5, 2023

Conversation

mauritsvanrees
Copy link
Sponsor Member

Fixes #334.

Screen shot of the rendered portlet (no css here) in the new test:

Screenshot 2023-09-01 at 18 39 10

@mister-roboto
Copy link

@mauritsvanrees thanks for creating this Pull Request and helping to improve Plone!

TL;DR: Finish pushing changes, pass all other checks, then paste a comment:

@jenkins-plone-org please run jobs

To ensure that these changes do not break other parts of Plone, the Plone test suite matrix needs to pass, but it takes 30-60 min. Other CI checks are usually much faster and the Plone Jenkins resources are limited, so when done pushing changes and all other checks pass either start all Jenkins PR jobs yourself, or simply add the comment above in this PR to start all the jobs automatically.

Happy hacking!

@mauritsvanrees
Copy link
Sponsor Member Author

The tox tests fail with:

ModuleNotFoundError: No module named 'plone.app.event'

No idea why. This is already the case on master.

Let's try Jenkins:

@jenkins-plone-org please run jobs

@jensens
Copy link
Sponsor Member

jensens commented Oct 5, 2023

@jenkins-plone-org please run jobs

@mauritsvanrees
Copy link
Sponsor Member Author

Two completely unrelated errors on Jenkins. I merge.

@mauritsvanrees mauritsvanrees merged commit 71757d6 into master Oct 5, 2023
10 of 12 checks passed
@mauritsvanrees mauritsvanrees deleted the maurits-test-long-event-master branch October 5, 2023 14:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

test_long_event fails early on the first of the month
4 participants