Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue 8 localization #10

Merged
merged 2 commits into from
Apr 26, 2015
Merged

Issue 8 localization #10

merged 2 commits into from
Apr 26, 2015

Conversation

keul
Copy link
Member

@keul keul commented Apr 17, 2015

See #8

@jensens
Copy link
Sponsor Member

jensens commented Apr 24, 2015

@jensens
Copy link
Sponsor Member

jensens commented Apr 24, 2015

oh, this is the 2.2 branch youre targeting on? whats with master?

@keul
Copy link
Member Author

keul commented Apr 25, 2015

@jensens I didn't find this view on master, no bloody idea if Plone 5 suffer this bug but the date selection is totally changed.

@jensens
Copy link
Sponsor Member

jensens commented Apr 26, 2015

in this case i do a merge now and check jenkins tomorrow...

jensens added a commit that referenced this pull request Apr 26, 2015
@jensens jensens merged commit da0259a into 2.2.x Apr 26, 2015
@jensens jensens deleted the issue-8-localization branch April 26, 2015 18:41
@keul
Copy link
Member Author

keul commented Apr 27, 2015

@gforcada uhmmm... that's weird. Sorry.
Do you need some help fixing it? The branch has been deleted

@jensens jensens restored the issue-8-localization branch April 27, 2015 07:55
@jensens
Copy link
Sponsor Member

jensens commented Apr 27, 2015

branch restored

@gforcada
Copy link
Sponsor Member

I finally got around to update our nodes and I pushed this: ba1e087 jenkins is running, let's see.

@gforcada
Copy link
Sponsor Member

@keul I can not reproduce your original issue locally, specially the python interactive session that you pasted, not only IT_it does not work (I'm on linux, same as jenkins) but on top of that if I fix the locale I get an empty string instead of a lowercase values for am/pm.

>>> import locale
>>> from datetime import datetime
>>> from datetime import timedelta

>>> datetime.now()
datetime.datetime(2015, 4, 27, 21, 43, 19, 33825)
>>> datetime.now() + timedelta(hours=9)
datetime.datetime(2015, 4, 28, 6, 43, 38, 119491)

>>> datetime.now().strftime("%p")
'PM'
>>> locale.setlocale(locale.LC_TIME, "IT_it")
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
  File "/usr/lib64/python2.7/locale.py", line 579, in setlocale
    return _setlocale(category, locale)
locale.Error: unsupported locale setting
>>> locale.setlocale(locale.LC_TIME, "it_IT")
'it_IT'
>>> datetime.now().strftime("%p")
''
>>> locale.setlocale(locale.LC_TIME, "en_US")
'en_US'
>>> datetime.now().strftime("%p")
'PM'
>>> locale.setlocale(locale.LC_TIME, "de_DE")
'de_DE'
>>> datetime.now().strftime("%p")
''
>>> datetime.now() + timedelta(hours=9)
datetime.datetime(2015, 4, 28, 6, 38, 13, 147529)
>>> (datetime.now() + timedelta(hours=9)).strftime("%p")
''

I will revert until it's properly fixed.

@jensens please don't merge pull requests if the pull request jenkins job already says that there are errors... that's what we created that jenkins job for to begin with.

gforcada added a commit that referenced this pull request Apr 27, 2015
This reverts commit da0259a, reversing
changes made to 0ece960.
@gforcada gforcada mentioned this pull request Apr 27, 2015
@jensens jensens deleted the issue-8-localization branch September 29, 2015 21:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants